Update google-protobuf and twirp dependencies #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Would be great if this could get merged, need it for our Ruby 3.4 upgrade 🙏 |
|
+1 on getting this merged because it's blocking other gems (e.g. anycable-rails) from being upgraded |
|
@davidzhao quick look here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates google-protobuf and twirp to the latest version.
I performed some manual API calls to verify behavior and the full test suite passes, everything seems to work as expected.
Additionally, I removed rack from the gemspec since the latest version of twirp already includes it as a sub-dependency.