这是indexloc提供的服务,不要输入任何密码
Skip to content

Use of unintialized responsive field #4028

@Melirius

Description

@Melirius

I have an impression that the use here of default -1 value converted to true

if (cparams_.decoding_speed_tier >= 1 && cparams_.responsive &&

is unintended as just a few lines lower the value is initialized

if (cparams_.responsive < 0) {
if (cparams_.ModularPartIsLossless()) {
cparams_.responsive = 0;
} else {
cparams_.responsive = 1;
}
}

This leads to paradoxical result that files encoded losslessly with and without -R 0 are different. I think initialization should be moved before this first use of responsive field.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions