-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Description
I have an impression that the use here of default -1 value converted to true
Line 476 in 24e12ba
| if (cparams_.decoding_speed_tier >= 1 && cparams_.responsive && |
is unintended as just a few lines lower the value is initialized
Lines 488 to 494 in 24e12ba
| if (cparams_.responsive < 0) { | |
| if (cparams_.ModularPartIsLossless()) { | |
| cparams_.responsive = 0; | |
| } else { | |
| cparams_.responsive = 1; | |
| } | |
| } |
This leads to paradoxical result that files encoded losslessly with and without -R 0 are different. I think initialization should be moved before this first use of responsive field.
Metadata
Metadata
Assignees
Labels
No labels