switches back to DeepDerivative as deployments were aggressively updated #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 74.73% 74.79% +0.05%
==========================================
Files 35 35
Lines 2569 2575 +6
==========================================
+ Hits 1920 1926 +6
Misses 582 582
Partials 67 67
Continue to review full report at Codecov.
|
gabo1208
approved these changes
May 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
When comparing the expected and actual, the actual has a few more defaults such as
terminationMessagePathandterminationMessagePolicy. This meant that the DeepEqual was claiming unequal more frequently than what was needed. The original fix with #605 is preserved by defaulting the parallelism env variable.