WIP - Switching to data-tiling fusion. #21441
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2025
hanhanW
added a commit
that referenced
this pull request
Jul 23, 2025
The compiler is very smart on static shape inference that can generate partially dynamic shape during the lowering. It makes data-tiling fusion very struggle because they are expected to be dynamic shape but some dimensions are inferred to static values in Stream AnnotateDispatchAssumptions pass. Because it will lead to `tensor.cast -> set_encoding -> tensor.cast` sequence in a dispatch, while we expect the bindings have encoded tensor types. E.g., Input IR: ```mlir %0 = iree_tensor_ext.dispatch_load ... tensor<?x?xi8> %1 = set_encoding %0 : tensor<?x?xi8> -> tensor<?x?xi8, #encoding> iree_tensor_ext.dispatch_store %1, ... tensor<?x?xi8, #encoding> -> ... tensor<?x?xi8, #encoding> ``` After annotation: ```mlir %0 = iree_tensor_ext.dispatch_load ... tensor<4x?xi8> %cast = tensor.cast %0 : tensor<4x?xi8> -> tensor<?x?xi8> %1 = set_encoding %cast : tensor<?x?xi8> -> tensor<?x?xi8, #encoding> %cast_0 = tensor.cast %1 : tensor<?x?xi8, #encoding> to tensor<4x5xi8> iree_tensor_ext.dispatch_store %cast_0, ... tensor<4x5xi8> -> ... tensor<?x?xi8, #encoding> ``` It is hard to materialize the encodings when cast op is present. Given that the original goal is testing dynamic shape, modifying the input program is an easier fix. The issue is observed from #21441. Signed-off-by: hanhanW <hanhan0912@gmail.com>
a2380b6 to
012f3a0
Compare
Signed-off-by: hanhanW <hanhan0912@gmail.com>
197faec to
01363d8
Compare
Signed-off-by: hanhanW <hanhan0912@gmail.com>
- Rename it to `materialize_encoding_vmvx.mlir` to follow the naming convention. - Delete the legacy `tensor.extract_slice` op from tests, because UnSetEncodingOp has slicing semantics. Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
It also replaces `TileAndFuse` pass uses with `TileRootAndFuseProducerConsumer` pass that may impact other dispatches, if they use DoubleTilingExpert. E.g., generic ops dispatches. Signed-off-by: hanhanW <hanhan0912@gmail.com>
…gConfigAttr. Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
…anonical form. Signed-off-by: hanhanW <hanhan0912@gmail.com>
…ibution passes. Signed-off-by: hanhanW <hanhan0912@gmail.com>
01363d8 to
efb04d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.