Cherry-pick "Restrict linalg.pack to not have extra padding sizes." #21424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97df042 to
e6c0a1e
Compare
bafc919 to
f0088dc
Compare
Signed-off-by: hanhanW <hanhan0912@gmail.com>
f0088dc to
ee9c0e3
Compare
|
@nirvedhmeshram @YashDeshpande25 FYI, @Max191 told me that this may impact your work, since I'm refining the pack/unpack semantics. See llvm/llvm-project#149624 for more details, the "artificial" padding is not allowed after I land it in upstream. The unpack op follows the constraint for matching the semantics. |
|
#21488 fixes the VMVX failure. The tensor_pad.mlir failure is legacy, I'll remove the support in other PR. |
|
It turns out that the legacy pass is not used at all, I'll delete it in #21489 |
Signed-off-by: hanhanW <hanhan0912@gmail.com>
- Rename it to `materialize_encoding_vmvx.mlir` to follow the naming convention. - Delete the legacy `tensor.extract_slice` op from tests, because UnSetEncodingOp has slicing semantics. Signed-off-by: hanhanW <hanhan0912@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.