[Util] Implement InferIntRangeInterface for OptimizationBarrierOp. #21501
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In softmax dispatch, there are two reduction ops. Only the root op is tiled for reduction dimensions when we switched to LLVMCPUTileRootAndFuseInputOperandsPass. It results in large vector sizes in the other reduction op when `util.assume.hint` ops are present. We did not hit the issue in e2e tests because AnnotateDispatchAssumptions pass behaves differently. The value range is [0, 0] if the input is from `flow.tensor.dynamic_constant`. Fixes iree-org#21359 Signed-off-by: hanhanW <hanhan0912@gmail.com>
The issue is identified from iree-org#21359 that the existing test does not reproduce the same issue. The reason is that the `hal.buffer_view.dim` op implements the interface while the `util.optimization_barrier` op does not implement the interface. The revision implements the interface for integrer and index types, so we can have consistent behavior between using IREE Check framework and user's input programs. Signed-off-by: hanhanW <hanhan0912@gmail.com>
benvanik
requested changes
Jul 26, 2025
There was a problem hiding this comment.
We can't do this with this op - the entire purpose of the op is to stop optimizations, and int range analysis is one of them. If tests are not representative of real user programs we should make them more representative via other mechanisms - optimization_barrier has a very specific purpose.
|
(e.g., reshape to the known shape after the optimization barrier so that the shape is knowable but the contents of the source tensor aren't, etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is identified from #21359 that the existing test does not reproduce the same issue. The reason is that the
hal.buffer_view.dimop implements the interface while theutil.optimization_barrierop does not implement the interface.The revision implements the interface for integer and index types, so we can have consistent behavior between using IREE Check framework and user's input programs.
Signed-off-by: hanhanW hanhan0912@gmail.com