这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: require Community and Observation taxon to match for RG #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kueda
Copy link
Member

@kueda kueda commented May 5, 2025

WEB-633

Closing the issue will require reassessing all existing RG obs, with the anticipated impact being ~0.25% of RG obs.

@jotamayo97
Copy link
Contributor

I'm really sorry for the noise, I'm just trying to understand this PR. With this change, the business rules are being modified, and we can now encounter situations like this:
image
where the community agrees on the genus but not on the species-level ID. I suppose all these texts would need to be updated as well, and maybe the "Has ID supported by two or more" item shouldn't be marked as completed in such cases.

I'm just asking to better understand the purpose of this, I'm not judging the PR itself.

Copy link
Member Author

kueda commented May 14, 2025

Yeah, updating the DQA was something I was working on yesterday, just pushed that commit. "Supported by two or more" is still accurate, there's just an additional requirement that the Observation Taxon match the Community Taxon. Currently we're blocked b/c we don't understand some of the ways the Observation Taxon gets set, so we need Scott to weigh in.

@kueda kueda marked this pull request as draft May 19, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants