-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersrefactoringKeeping that code clean!Keeping that code clean!
Description
Version: 0.19.0
Strongly related: #3359
Our config contains several URLs and they are all strings (frontendUrl, databaseUrl, serverUrl, apiUrl, etc.). Whenever we want to do something with them, we call new URL and go from there.
Why not create URL objects as soon as possible and just save those inside the config? Like this
// ...
databaseUrl: URL;
frontendUrl: URL;
serverUrl: URL;Benefits:
- We'd have a much easier time parsing the URL once and then working with
URLobjects than we do callingnew URLin a bunch of places. - It solves all problems described in Have a proper type for URLs we validated #3359.
- It would probably benefit our users too.
The task:
- Decide whether this makes sense (think about how it affects users).
- Consider the other possibility: Have a proper type for URLs we validated #3359
- If the change is viable, implement it.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersrefactoringKeeping that code clean!Keeping that code clean!