Add tel and username attributes
#718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes `name` and `email` optional but requires that one of these four is provided. Bug: w3c-fedid#435
TallTed
reviewed
Apr 16, 2025
samuelgoto
approved these changes
Apr 16, 2025
TallTed
reviewed
Apr 16, 2025
Collaborator
Author
|
I addressed Ted's two comments. |
Collaborator
Author
|
I have updated the PR to change "phone" to "tel". This matches HTML5 instead of inventing a new term. |
Collaborator
Added agenda+ in case we wanna discuss this question? |
TallTed
reviewed
Apr 16, 2025
npm1
reviewed
Apr 17, 2025
| }, { | ||
| "id": "5678", | ||
| "given_name": "Johnny", | ||
| "name": "Johnny", |
Collaborator
Author
There was a problem hiding this comment.
I wanted an example to show that you don't need to specify name and email anymore.
Collaborator
There was a problem hiding this comment.
Would it make sense to have an example with the new attributes then?
Collaborator
Author
|
On Thu, Apr 17, 2025, 14:17 Nicolás Peña Moreno ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/index.bs
<#718 (comment)>:
> @@ -1238,7 +1238,14 @@ returns an {{IdentityProviderAccountList}}.
|responseBody|.
1. [=converted to an IDL value|Convert=] |json| to an {{IdentityProviderAccountList}}, and
store the result in |accountsList|.
- 1. If one of the previous two steps threw an exception, set |accountsList| to failure.
+ 1. If one of the previous two steps threw an exception, or if there is an account in
+ |accountsList| that has neither {{IdentityProviderAccount/email}}, {{IdentityProviderAccount/name}},
+ {{IdentityProviderAccount/tel}}, nor {{IdentityProviderAccount/username}} set, set |accountsList|
Where does the spec say to reject everything if an account is missing name
or ID?
They are marked `required`, so their absence makes the previous step throw
an exception.
—
… Reply to this email directly, view it on GitHub
<#718 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALKCZI23HMNEPOHNFCZSQL2Z7V4HAVCNFSM6AAAAAB3JHT6Y2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZWGU4DGMBWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
TallTed
reviewed
Apr 17, 2025
npm1
approved these changes
Apr 17, 2025
bvandersloot-mozilla
approved these changes
Apr 22, 2025
Contributor
|
Discussed during the FedID WG/CG meeting 22 April 2025 https://github.com/w3c-fedid/meetings/blob/main/2025/2025-04-22-FedCM-agenda.md |
phone and username attributestel and username attributes
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Apr 22, 2025
SHA: 7ed3425 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes
nameandemailoptional but requires that one of these four is provided.Bug: #435
Preview | Diff