From 3e8410301138410c655b27704879f614feb3512d Mon Sep 17 00:00:00 2001 From: Alex Supkay Date: Fri, 14 Feb 2025 12:28:33 -0500 Subject: [PATCH 1/3] Standard type check job name to check-types --- examples/with-shell-commands/README.md | 2 +- examples/with-shell-commands/apps/app-a/package.json | 2 +- examples/with-shell-commands/apps/app-b/package.json | 2 +- examples/with-shell-commands/packages/pkg-a/package.json | 2 +- examples/with-shell-commands/packages/pkg-b/package.json | 2 +- examples/with-shell-commands/turbo.json | 2 +- examples/with-typeorm/package.json | 2 +- examples/with-typeorm/packages/typeorm-service/package.json | 2 +- examples/with-typeorm/turbo.json | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/with-shell-commands/README.md b/examples/with-shell-commands/README.md index 084f556dbd7d2..d7f0e717b174a 100644 --- a/examples/with-shell-commands/README.md +++ b/examples/with-shell-commands/README.md @@ -36,7 +36,7 @@ This Turborepo includes the following packages: If you haven't yet, [install global `turbo`](https://turbo.build/repo/docs/installing#install-globally) to run tasks. -- `turbo build lint type-check`: Runs all tasks in the default graph. +- `turbo build lint check-types`: Runs all tasks in the default graph. - `turbo build`: A basic command to build `app-a` and `app-b` in parallel. - `turbo build --filter=app-a`: Building only `app-a` and its dependencies. - `turbo lint`: A basic command for running lints in all packages in parallel. diff --git a/examples/with-shell-commands/apps/app-a/package.json b/examples/with-shell-commands/apps/app-a/package.json index 770491511d77c..98b4703a97ade 100644 --- a/examples/with-shell-commands/apps/app-a/package.json +++ b/examples/with-shell-commands/apps/app-a/package.json @@ -4,7 +4,7 @@ "scripts": { "build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application A is built!\"", "lint": "echo \"Linted!\"", - "type-check": "echo \"Types checked!\"" + "check-types": "echo \"Types checked!\"" }, "dependencies": { "pkg-a": "workspace:*", diff --git a/examples/with-shell-commands/apps/app-b/package.json b/examples/with-shell-commands/apps/app-b/package.json index 9cb2e1941ece7..763f8d139582f 100644 --- a/examples/with-shell-commands/apps/app-b/package.json +++ b/examples/with-shell-commands/apps/app-b/package.json @@ -4,7 +4,7 @@ "scripts": { "build": "mkdir -p dist && echo \"Your application output!\" > dist/app-output.txt && echo \"Application B is built!\"", "lint": "echo \"Linted!\"", - "type-check": "echo \"Types checked!\"" + "check-types": "echo \"Types checked!\"" }, "dependencies": { "tooling-config": "workspace:*" diff --git a/examples/with-shell-commands/packages/pkg-a/package.json b/examples/with-shell-commands/packages/pkg-a/package.json index 1d60de1da4eee..551ad943db792 100644 --- a/examples/with-shell-commands/packages/pkg-a/package.json +++ b/examples/with-shell-commands/packages/pkg-a/package.json @@ -3,7 +3,7 @@ "scripts": { "build": "echo \"Building at the speed of Turbo.\" > output-file.txt && cat output-file.txt", "lint": "echo \"Linted!\"", - "type-check": "echo \"Types checked!\"" + "check-types": "echo \"Types checked!\"" }, "dependencies": { "tooling-config": "workspace:*" diff --git a/examples/with-shell-commands/packages/pkg-b/package.json b/examples/with-shell-commands/packages/pkg-b/package.json index 01701e59eb66f..73c2fd5a82f10 100644 --- a/examples/with-shell-commands/packages/pkg-b/package.json +++ b/examples/with-shell-commands/packages/pkg-b/package.json @@ -3,7 +3,7 @@ "scripts": { "prebuild": "echo \"Executing pre-build step...\"", "build": "echo \"Welcome to the Turboverse.\" > output-file.txt && cat output-file.txt", - "type-check": "echo \"Types checked!\"" + "check-types": "echo \"Types checked!\"" }, "dependencies": { "tooling-config": "workspace:*" diff --git a/examples/with-shell-commands/turbo.json b/examples/with-shell-commands/turbo.json index 333ea4561910a..e85ec3a3ff84a 100644 --- a/examples/with-shell-commands/turbo.json +++ b/examples/with-shell-commands/turbo.json @@ -13,6 +13,6 @@ }, "prebuild": {}, "lint": {}, - "type-check": {} + "check-types": {} } } diff --git a/examples/with-typeorm/package.json b/examples/with-typeorm/package.json index 2cb8c537487f4..4d720385cc7db 100644 --- a/examples/with-typeorm/package.json +++ b/examples/with-typeorm/package.json @@ -4,7 +4,7 @@ "build": "turbo build", "dev": "turbo dev", "lint": "turbo lint", - "type-check": "turbo type-check", + "check-types": "turbo check-types", "format": "prettier --write \"**/*.{ts,tsx,md}\"" }, "devDependencies": { diff --git a/examples/with-typeorm/packages/typeorm-service/package.json b/examples/with-typeorm/packages/typeorm-service/package.json index 7e8551b4c54c2..c015fc10329e6 100644 --- a/examples/with-typeorm/packages/typeorm-service/package.json +++ b/examples/with-typeorm/packages/typeorm-service/package.json @@ -9,7 +9,7 @@ "lint": "eslint src/ --max-warnings 0", "test:watch": "vitest", "test": "vitest run", - "type-check": "tsc --noEmit" + "check-types": "tsc --noEmit" }, "peerDependencies": { "typeorm": "^0.3.20" diff --git a/examples/with-typeorm/turbo.json b/examples/with-typeorm/turbo.json index bed99808b6b14..c77e9b3d12fb3 100644 --- a/examples/with-typeorm/turbo.json +++ b/examples/with-typeorm/turbo.json @@ -9,7 +9,7 @@ "lint": { "dependsOn": ["^lint"] }, - "type-check": {}, + "check-types": {}, "test": { "cache": false, "inputs": ["**/*.test.ts", "**/*.test.tsx", "vitest.config.ts"] From 33aa241ef1c28aff2508b27f4c27b93a34804f7b Mon Sep 17 00:00:00 2001 From: Alex Supkay Date: Fri, 14 Feb 2025 12:36:31 -0500 Subject: [PATCH 2/3] Modify with-gatsby's check types command --- examples/with-gatsby/apps/web/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/with-gatsby/apps/web/package.json b/examples/with-gatsby/apps/web/package.json index d47994caa7630..f29339f369712 100644 --- a/examples/with-gatsby/apps/web/package.json +++ b/examples/with-gatsby/apps/web/package.json @@ -6,7 +6,7 @@ "dev": "gatsby develop", "build": "gatsby build", "start": "gatsby develop", - "typecheck": "tsc --noEmit", + "check-types": "tsc --noEmit", "lint": "eslint src/ --max-warnings 0" }, "dependencies": { From 2ed42874331c002c6887372b26d674ecaf2c77d6 Mon Sep 17 00:00:00 2001 From: Alex Supkay Date: Fri, 14 Feb 2025 12:41:54 -0500 Subject: [PATCH 3/3] Move with-vue-nuxt to check-types --- examples/with-vue-nuxt/apps/web/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/with-vue-nuxt/apps/web/package.json b/examples/with-vue-nuxt/apps/web/package.json index c5040aedb2ecf..77c0540d856e7 100644 --- a/examples/with-vue-nuxt/apps/web/package.json +++ b/examples/with-vue-nuxt/apps/web/package.json @@ -4,10 +4,10 @@ "private": true, "scripts": { "dev": "vite --port 3000", - "build": "run-p type-check \"build-only {@}\" --", + "build": "run-p check-types \"build-only {@}\" --", "preview": "vite preview", "build-only": "vite build", - "type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false", + "check-types": "vue-tsc --noEmit -p tsconfig.app.json --composite false", "lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore" }, "dependencies": {