From 1173f2830b67e1dd7486014cce648913c650f446 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Mon, 27 Jan 2025 13:45:30 -0700 Subject: [PATCH 01/17] ci: add to examples testing --- turborepo-tests/helpers/setup_example_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 63f38b6c1511d..07ef608b05364 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -37,7 +37,7 @@ fi # All examples implement these two tasks # and it's reasonable to assume that they will continue to do so -turbo_command="turbo build lint --continue --output-logs=errors-only" +turbo_command="turbo build lint check-types --continue --output-logs=errors-only" # Head into a temporary directory mkdir -p ../../examples-tests-tmp From 65811bed714e1f65f17accc0a005d234bec61c4a Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Mon, 27 Jan 2025 14:15:08 -0700 Subject: [PATCH 02/17] Update turborepo-tests/helpers/setup_example_test.sh --- turborepo-tests/helpers/setup_example_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 07ef608b05364..473cce298cb2c 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -37,7 +37,7 @@ fi # All examples implement these two tasks # and it's reasonable to assume that they will continue to do so -turbo_command="turbo build lint check-types --continue --output-logs=errors-only" +turbo_command="turbo build && turbo lint && turbo check-types --continue --output-logs=errors-only" # Head into a temporary directory mkdir -p ../../examples-tests-tmp From 4745b688ffec88342c7c1b07f5c27e0fe206c524 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 21:41:49 -0700 Subject: [PATCH 03/17] WIP --- examples/kitchen-sink/apps/admin/package.json | 10 +- examples/kitchen-sink/apps/api/package.json | 7 +- examples/kitchen-sink/apps/blog/package.json | 8 +- .../kitchen-sink/apps/storefront/package.json | 9 +- .../packages/config-eslint/package.json | 7 + .../packages/config-typescript/package.json | 9 + .../packages/jest-presets/package.json | 9 +- .../kitchen-sink/packages/logger/package.json | 7 + .../kitchen-sink/packages/ui/package.json | 11 +- examples/kitchen-sink/pnpm-lock.yaml | 283 ++++++++---------- turborepo-tests/helpers/setup_example_test.sh | 2 +- 11 files changed, 183 insertions(+), 179 deletions(-) diff --git a/examples/kitchen-sink/apps/admin/package.json b/examples/kitchen-sink/apps/admin/package.json index 45bb4f6a33f08..575b929eb78a2 100644 --- a/examples/kitchen-sink/apps/admin/package.json +++ b/examples/kitchen-sink/apps/admin/package.json @@ -11,16 +11,16 @@ }, "dependencies": { "@repo/ui": "workspace:*", - "react": "^19.0.0", - "react-dom": "^19.0.0" + "react": "^18.3.1" }, "devDependencies": { "@repo/eslint-config": "workspace:*", "@repo/typescript-config": "workspace:*", - "@types/react": "^19.0.8", - "@types/react-dom": "^19.0.3", + "@types/react": "^18.3.18", + "@types/react-dom": "^18.3.5", "@vitejs/plugin-react": "^4.3.4", + "react-dom": "^18.3.1", "typescript": "5.7.3", - "vite": "^6.0.11" + "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/apps/api/package.json b/examples/kitchen-sink/apps/api/package.json index a9fad1d0ee7aa..3ce000ef9c2bd 100644 --- a/examples/kitchen-sink/apps/api/package.json +++ b/examples/kitchen-sink/apps/api/package.json @@ -19,7 +19,9 @@ "body-parser": "^1.20.3", "cors": "^2.8.5", "express": "^5.0.1", - "morgan": "^1.10.0" + "morgan": "^1.10.0", + "react": "^18.2.0", + "vite": "^5.4.14" }, "devDependencies": { "@jest/globals": "^29.7.0", @@ -31,8 +33,11 @@ "@types/express": "4.17.17", "@types/morgan": "^1.9.9", "@types/node": "^22.10.10", + "@types/react": "^18.2.20", + "@types/react-dom": "^18.2.7", "@types/supertest": "^6.0.2", "jest": "^29.7.0", + "react-dom": "^18.2.0", "supertest": "^7.0.0", "tsup": "^8.3.6", "typescript": "5.7.3" diff --git a/examples/kitchen-sink/apps/blog/package.json b/examples/kitchen-sink/apps/blog/package.json index 428416c0ece15..5f0d97969529d 100644 --- a/examples/kitchen-sink/apps/blog/package.json +++ b/examples/kitchen-sink/apps/blog/package.json @@ -18,13 +18,13 @@ "@vercel/analytics": "^1.4.1", "@vercel/remix": "2.15.2", "isbot": "^5.1.21", - "react": "^18.2.0", - "react-dom": "^18.2.0" + "react": "^18.3.1", + "react-dom": "^18.3.1" }, "devDependencies": { "@remix-run/dev": "^2.15.2", - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", + "@types/react": "^18.3.18", + "@types/react-dom": "^18.3.5", "@typescript-eslint/eslint-plugin": "^8.22.0", "@typescript-eslint/parser": "^8.22.0", "@vercel/remix": "2.15.2", diff --git a/examples/kitchen-sink/apps/storefront/package.json b/examples/kitchen-sink/apps/storefront/package.json index 7d25cb78b6f39..4c16e0c602fc0 100644 --- a/examples/kitchen-sink/apps/storefront/package.json +++ b/examples/kitchen-sink/apps/storefront/package.json @@ -14,16 +14,17 @@ "@repo/logger": "workspace:*", "@repo/ui": "workspace:*", "next": "^15.1.6", - "react": "^19.0.0", - "react-dom": "^19.0.0" + "react": "^18.3.1", + "vite": "^5.4.14" }, "devDependencies": { "@next/eslint-plugin-next": "^15.1.6", "@repo/eslint-config": "workspace:*", "@repo/typescript-config": "workspace:*", "@types/node": "^22.10.10", - "@types/react": "^19.0.8", - "@types/react-dom": "^19.0.3", + "@types/react": "^18.3.18", + "@types/react-dom": "^18.3.5", + "react-dom": "^18.3.1", "typescript": "5.7.3" } } diff --git a/examples/kitchen-sink/packages/config-eslint/package.json b/examples/kitchen-sink/packages/config-eslint/package.json index 784c9e55bc314..531722d5417df 100644 --- a/examples/kitchen-sink/packages/config-eslint/package.json +++ b/examples/kitchen-sink/packages/config-eslint/package.json @@ -13,6 +13,8 @@ "devDependencies": { "@eslint/js": "^9.19.0", "@next/eslint-plugin-next": "^15.1.6", + "@types/react": "^18.2.20", + "@types/react-dom": "^18.2.7", "eslint": "^9.19.0", "eslint-config-prettier": "^10.0.1", "eslint-plugin-only-warn": "^1.1.0", @@ -20,7 +22,12 @@ "eslint-plugin-react-hooks": "^5.1.0", "eslint-plugin-turbo": "^2.3.4", "globals": "^15.14.0", + "react-dom": "^18.2.0", "typescript": "^5.7.3", "typescript-eslint": "^8.22.0" + }, + "dependencies": { + "react": "^18.2.0", + "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/packages/config-typescript/package.json b/examples/kitchen-sink/packages/config-typescript/package.json index 27c0e60436aac..f31ce631e7c5b 100644 --- a/examples/kitchen-sink/packages/config-typescript/package.json +++ b/examples/kitchen-sink/packages/config-typescript/package.json @@ -5,5 +5,14 @@ "license": "MIT", "publishConfig": { "access": "public" + }, + "dependencies": { + "react": "^18.2.0", + "vite": "^5.4.14" + }, + "devDependencies": { + "@types/react": "^18.2.20", + "@types/react-dom": "^18.2.7", + "react-dom": "^18.2.0" } } diff --git a/examples/kitchen-sink/packages/jest-presets/package.json b/examples/kitchen-sink/packages/jest-presets/package.json index e6567cc7dcd1b..e82a2b934b54e 100644 --- a/examples/kitchen-sink/packages/jest-presets/package.json +++ b/examples/kitchen-sink/packages/jest-presets/package.json @@ -9,9 +9,14 @@ ], "dependencies": { "jest": "^29.7.0", - "ts-jest": "^29.2.5" + "react": "^18.2.0", + "ts-jest": "^29.2.5", + "vite": "^5.4.14" }, "devDependencies": { - "jest-environment-jsdom": "^29.7.0" + "@types/react": "^18.2.20", + "@types/react-dom": "^18.2.7", + "jest-environment-jsdom": "^29.7.0", + "react-dom": "^18.2.0" } } diff --git a/examples/kitchen-sink/packages/logger/package.json b/examples/kitchen-sink/packages/logger/package.json index 1c26a2d7b75c6..52b79dfd63db8 100644 --- a/examples/kitchen-sink/packages/logger/package.json +++ b/examples/kitchen-sink/packages/logger/package.json @@ -24,9 +24,16 @@ "@repo/jest-presets": "workspace:*", "@repo/typescript-config": "workspace:*", "@types/node": "^22.10.10", + "@types/react": "^18.2.20", + "@types/react-dom": "^18.2.7", "eslint": "^9.19.0", "jest": "^29.7.0", + "react-dom": "^18.2.0", "tsup": "^8.3.6", "typescript": "5.7.3" + }, + "dependencies": { + "react": "^18.2.0", + "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/packages/ui/package.json b/examples/kitchen-sink/packages/ui/package.json index deb4ad122817d..d3cdcc6a5a51d 100644 --- a/examples/kitchen-sink/packages/ui/package.json +++ b/examples/kitchen-sink/packages/ui/package.json @@ -35,12 +35,15 @@ "@repo/jest-presets": "workspace:*", "@repo/typescript-config": "workspace:*", "@types/node": "^22.10.10", - "@types/react": "^19.0.8", - "@types/react-dom": "^19.0.3", + "@types/react": "^18.3.18", + "@types/react-dom": "^18.3.5", "jest": "^29.7.0", - "react": "^19.0.0", - "react-dom": "^19.0.0", + "react": "^18.3.1", + "react-dom": "^18.3.1", "tsup": "^8.3.6", "typescript": "5.7.3" + }, + "dependencies": { + "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/pnpm-lock.yaml b/examples/kitchen-sink/pnpm-lock.yaml index 078fea5897a60..1677708f03198 100644 --- a/examples/kitchen-sink/pnpm-lock.yaml +++ b/examples/kitchen-sink/pnpm-lock.yaml @@ -21,11 +21,8 @@ importers: specifier: workspace:* version: link:../../packages/ui react: - specifier: ^19.0.0 - version: 19.0.0 - react-dom: - specifier: ^19.0.0 - version: 19.0.0(react@19.0.0) + specifier: ^18.3.1 + version: 18.3.1 devDependencies: '@repo/eslint-config': specifier: workspace:* @@ -34,20 +31,23 @@ importers: specifier: workspace:* version: link:../../packages/config-typescript '@types/react': - specifier: ^19.0.8 - version: 19.0.8 + specifier: ^18.3.18 + version: 18.3.18 '@types/react-dom': - specifier: ^19.0.3 - version: 19.0.3(@types/react@19.0.8) + specifier: ^18.3.5 + version: 18.3.5(@types/react@18.3.18) '@vitejs/plugin-react': specifier: ^4.3.4 - version: 4.3.4(vite@6.0.11(@types/node@22.10.10)(yaml@2.7.0)) + version: 4.3.4(vite@5.4.14(@types/node@22.10.10)) + react-dom: + specifier: ^18.3.1 + version: 18.3.1(react@18.3.1) typescript: specifier: 5.7.3 version: 5.7.3 vite: - specifier: ^6.0.11 - version: 6.0.11(@types/node@22.10.10)(yaml@2.7.0) + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) apps/api: dependencies: @@ -66,6 +66,12 @@ importers: morgan: specifier: ^1.10.0 version: 1.10.0 + react: + specifier: ^18.2.0 + version: 18.3.1 + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -94,12 +100,21 @@ importers: '@types/node': specifier: ^22.10.10 version: 22.10.10 + '@types/react': + specifier: ^18.2.20 + version: 18.3.18 + '@types/react-dom': + specifier: ^18.2.7 + version: 18.3.5(@types/react@18.3.18) '@types/supertest': specifier: ^6.0.2 version: 6.0.2 jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) + react-dom: + specifier: ^18.2.0 + version: 18.3.1(react@18.3.1) supertest: specifier: ^7.0.0 version: 7.0.0 @@ -134,20 +149,20 @@ importers: specifier: ^5.1.21 version: 5.1.21 react: - specifier: ^18.2.0 + specifier: ^18.3.1 version: 18.3.1 react-dom: - specifier: ^18.2.0 + specifier: ^18.3.1 version: 18.3.1(react@18.3.1) devDependencies: '@remix-run/dev': specifier: ^2.15.2 version: 2.15.2(@remix-run/react@2.15.2(react-dom@18.3.1(react@18.3.1))(react@18.3.1)(typescript@5.7.3))(@types/node@22.10.10)(typescript@5.7.3)(vite@5.4.14(@types/node@22.10.10)) '@types/react': - specifier: ^18.2.20 + specifier: ^18.3.18 version: 18.3.18 '@types/react-dom': - specifier: ^18.2.7 + specifier: ^18.3.5 version: 18.3.5(@types/react@18.3.18) '@typescript-eslint/eslint-plugin': specifier: ^8.22.0 @@ -181,13 +196,13 @@ importers: version: link:../../packages/ui next: specifier: ^15.1.6 - version: 15.1.6(react-dom@19.0.0(react@19.0.0))(react@19.0.0) + version: 15.1.6(@babel/core@7.26.7)(react-dom@18.3.1(react@18.3.1))(react@18.3.1) react: - specifier: ^19.0.0 - version: 19.0.0 - react-dom: - specifier: ^19.0.0 - version: 19.0.0(react@19.0.0) + specifier: ^18.3.1 + version: 18.3.1 + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: '@next/eslint-plugin-next': specifier: ^15.1.6 @@ -202,16 +217,26 @@ importers: specifier: ^22.10.10 version: 22.10.10 '@types/react': - specifier: ^19.0.8 - version: 19.0.8 + specifier: ^18.3.18 + version: 18.3.18 '@types/react-dom': - specifier: ^19.0.3 - version: 19.0.3(@types/react@19.0.8) + specifier: ^18.3.5 + version: 18.3.5(@types/react@18.3.18) + react-dom: + specifier: ^18.3.1 + version: 18.3.1(react@18.3.1) typescript: specifier: 5.7.3 version: 5.7.3 packages/config-eslint: + dependencies: + react: + specifier: ^18.2.0 + version: 18.3.1 + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: '@eslint/js': specifier: ^9.19.0 @@ -219,6 +244,12 @@ importers: '@next/eslint-plugin-next': specifier: ^15.1.6 version: 15.1.6 + '@types/react': + specifier: ^18.2.20 + version: 18.3.18 + '@types/react-dom': + specifier: ^18.2.7 + version: 18.3.5(@types/react@18.3.18) eslint: specifier: ^9.19.0 version: 9.19.0 @@ -240,6 +271,9 @@ importers: globals: specifier: ^15.14.0 version: 15.14.0 + react-dom: + specifier: ^18.2.0 + version: 18.3.1(react@18.3.1) typescript: specifier: ^5.7.3 version: 5.7.3 @@ -247,22 +281,61 @@ importers: specifier: ^8.22.0 version: 8.22.0(eslint@9.19.0)(typescript@5.7.3) - packages/config-typescript: {} + packages/config-typescript: + dependencies: + react: + specifier: ^18.2.0 + version: 18.3.1 + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) + devDependencies: + '@types/react': + specifier: ^18.2.20 + version: 18.3.18 + '@types/react-dom': + specifier: ^18.2.7 + version: 18.3.5(@types/react@18.3.18) + react-dom: + specifier: ^18.2.0 + version: 18.3.1(react@18.3.1) packages/jest-presets: dependencies: jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) + react: + specifier: ^18.2.0 + version: 18.3.1 ts-jest: specifier: ^29.2.5 - version: 29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0)(typescript@5.7.3) + version: 29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0(@types/node@22.10.10))(typescript@5.7.3) + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: + '@types/react': + specifier: ^18.2.20 + version: 18.3.18 + '@types/react-dom': + specifier: ^18.2.7 + version: 18.3.5(@types/react@18.3.18) jest-environment-jsdom: specifier: ^29.7.0 version: 29.7.0 + react-dom: + specifier: ^18.2.0 + version: 18.3.1(react@18.3.1) packages/logger: + dependencies: + react: + specifier: ^18.2.0 + version: 18.3.1 + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -279,12 +352,21 @@ importers: '@types/node': specifier: ^22.10.10 version: 22.10.10 + '@types/react': + specifier: ^18.2.20 + version: 18.3.18 + '@types/react-dom': + specifier: ^18.2.7 + version: 18.3.5(@types/react@18.3.18) eslint: specifier: ^9.19.0 version: 9.19.0 jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) + react-dom: + specifier: ^18.2.0 + version: 18.3.1(react@18.3.1) tsup: specifier: ^8.3.6 version: 8.3.6(postcss@8.5.1)(typescript@5.7.3)(yaml@2.7.0) @@ -293,6 +375,10 @@ importers: version: 5.7.3 packages/ui: + dependencies: + vite: + specifier: ^5.4.14 + version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -310,20 +396,20 @@ importers: specifier: ^22.10.10 version: 22.10.10 '@types/react': - specifier: ^19.0.8 - version: 19.0.8 + specifier: ^18.3.18 + version: 18.3.18 '@types/react-dom': - specifier: ^19.0.3 - version: 19.0.3(@types/react@19.0.8) + specifier: ^18.3.5 + version: 18.3.5(@types/react@18.3.18) jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) react: - specifier: ^19.0.0 - version: 19.0.0 + specifier: ^18.3.1 + version: 18.3.1 react-dom: - specifier: ^19.0.0 - version: 19.0.0(react@19.0.0) + specifier: ^18.3.1 + version: 18.3.1(react@18.3.1) tsup: specifier: ^8.3.6 version: 8.3.6(postcss@8.5.1)(typescript@5.7.3)(yaml@2.7.0) @@ -1629,17 +1715,9 @@ packages: peerDependencies: '@types/react': ^18.0.0 - '@types/react-dom@19.0.3': - resolution: {integrity: sha512-0Knk+HJiMP/qOZgMyNFamlIjw9OFCsyC2ZbigmEEyXXixgre6IQpm/4V+r3qH4GC1JPvRJKInw+on2rV6YZLeA==} - peerDependencies: - '@types/react': ^19.0.0 - '@types/react@18.3.18': resolution: {integrity: sha512-t4yC+vtgnkYjNSKlFx1jkAhH8LgTo2N/7Qvi83kdEaUtMDiwpbLAktKDaAMlRcJ5eSxZkH74eEGt1ky31d7kfQ==} - '@types/react@19.0.8': - resolution: {integrity: sha512-9P/o1IGdfmQxrujGbIMDyYaaCykhLKc0NGCtYcECNUr9UAaDe4gwvV9bR6tvd5Br1SG0j+PBpbKr2UYY8CwqSw==} - '@types/send@0.17.4': resolution: {integrity: sha512-x2EM6TJOybec7c52BX0ZspPodMsQUd5L6PRwOunVyVUhXiBSKf3AezDL8Dgvgt5o0UfKNfuA0eMLr2wLT4AiBA==} @@ -4237,11 +4315,6 @@ packages: peerDependencies: react: ^18.3.1 - react-dom@19.0.0: - resolution: {integrity: sha512-4GV5sHFG0e/0AD4X+ySy6UJd3jVl1iNsNHdpad0qhABJ11twS3TTBnseqsKurKcsNqCEFeGL3uLpVChpIO3QfQ==} - peerDependencies: - react: ^19.0.0 - react-is@16.13.1: resolution: {integrity: sha512-24e6ynE2H+OKt4kqsOvNd8kBpV65zoxbA4BVsEOB3ARVWQki/DHzaUoC5KuON/BiccDaCCTZBuOcfZs70kR8bQ==} @@ -4269,10 +4342,6 @@ packages: resolution: {integrity: sha512-wS+hAgJShR0KhEvPJArfuPVN1+Hz1t0Y6n5jLrGQbkb4urgPE/0Rve+1kMB1v/oWgHgm4WIcV+i7F2pTVj+2iQ==} engines: {node: '>=0.10.0'} - react@19.0.0: - resolution: {integrity: sha512-V8AVnmPIICiWpGfm6GLzCR/W5FXLchHop40W4nXBmdlEceh16rCN8O8LNWm5bh5XUX91fh7KpA+W0TgMKmgTpQ==} - engines: {node: '>=0.10.0'} - readable-stream@2.3.8: resolution: {integrity: sha512-8p0AUk4XODgIewSi0l8Epjs+EVnWiK7NoDIEGU0HhE7+ZyY8D1IMY7odu5lRrFXGg71L15KG8QrPmum45RTtdA==} @@ -4410,9 +4479,6 @@ packages: scheduler@0.23.2: resolution: {integrity: sha512-UOShsPwz7NrMUqhR6t0hWjFduvOzbtv7toDH1/hIrfRNIDBnnBWd0CwJTGvTpngVlmwGCdP9/Zl/tVrDqcuYzQ==} - scheduler@0.25.0: - resolution: {integrity: sha512-xFVuu11jh+xcO7JOAGJNOXld8/TcEHK/4CituBUeUb5hqxJLj9YuemAEuvm9gQ/+pgXYfbQuqAkiYu+u7YEsNA==} - semver@6.3.1: resolution: {integrity: sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==} hasBin: true @@ -5062,46 +5128,6 @@ packages: terser: optional: true - vite@6.0.11: - resolution: {integrity: sha512-4VL9mQPKoHy4+FE0NnRE/kbY51TOfaknxAjt3fJbGJxhIpBZiqVzlZDEesWWsuREXHwNdAoOFZ9MkPEVXczHwg==} - engines: {node: ^18.0.0 || ^20.0.0 || >=22.0.0} - hasBin: true - peerDependencies: - '@types/node': ^18.0.0 || ^20.0.0 || >=22.0.0 - jiti: '>=1.21.0' - less: '*' - lightningcss: ^1.21.0 - sass: '*' - sass-embedded: '*' - stylus: '*' - sugarss: '*' - terser: ^5.16.0 - tsx: ^4.8.1 - yaml: ^2.4.2 - peerDependenciesMeta: - '@types/node': - optional: true - jiti: - optional: true - less: - optional: true - lightningcss: - optional: true - sass: - optional: true - sass-embedded: - optional: true - stylus: - optional: true - sugarss: - optional: true - terser: - optional: true - tsx: - optional: true - yaml: - optional: true - w3c-xmlserializer@4.0.0: resolution: {integrity: sha512-d+BFHzbiCx6zGfz0HyQ6Rg69w9k19nviJspaj4yNscGjrHu94sVP+aRm75yEbCh+r2/yR+7q6hux9LVtbuTGBw==} engines: {node: '>=14'} @@ -6534,19 +6560,11 @@ snapshots: dependencies: '@types/react': 18.3.18 - '@types/react-dom@19.0.3(@types/react@19.0.8)': - dependencies: - '@types/react': 19.0.8 - '@types/react@18.3.18': dependencies: '@types/prop-types': 15.7.14 csstype: 3.1.3 - '@types/react@19.0.8': - dependencies: - csstype: 3.1.3 - '@types/send@0.17.4': dependencies: '@types/mime': 1.3.5 @@ -6734,14 +6752,14 @@ snapshots: json-schema-to-ts: 1.6.4 ts-morph: 12.0.0 - '@vitejs/plugin-react@4.3.4(vite@6.0.11(@types/node@22.10.10)(yaml@2.7.0))': + '@vitejs/plugin-react@4.3.4(vite@5.4.14(@types/node@22.10.10))': dependencies: '@babel/core': 7.26.7 '@babel/plugin-transform-react-jsx-self': 7.25.9(@babel/core@7.26.7) '@babel/plugin-transform-react-jsx-source': 7.25.9(@babel/core@7.26.7) '@types/babel__core': 7.20.5 react-refresh: 0.14.2 - vite: 6.0.11(@types/node@22.10.10)(yaml@2.7.0) + vite: 5.4.14(@types/node@22.10.10) transitivePeerDependencies: - supports-color @@ -9450,32 +9468,6 @@ snapshots: transitivePeerDependencies: - '@babel/core' - babel-plugin-macros - optional: true - - next@15.1.6(react-dom@19.0.0(react@19.0.0))(react@19.0.0): - dependencies: - '@next/env': 15.1.6 - '@swc/counter': 0.1.3 - '@swc/helpers': 0.5.15 - busboy: 1.6.0 - caniuse-lite: 1.0.30001695 - postcss: 8.4.31 - react: 19.0.0 - react-dom: 19.0.0(react@19.0.0) - styled-jsx: 5.1.6(react@19.0.0) - optionalDependencies: - '@next/swc-darwin-arm64': 15.1.6 - '@next/swc-darwin-x64': 15.1.6 - '@next/swc-linux-arm64-gnu': 15.1.6 - '@next/swc-linux-arm64-musl': 15.1.6 - '@next/swc-linux-x64-gnu': 15.1.6 - '@next/swc-linux-x64-musl': 15.1.6 - '@next/swc-win32-arm64-msvc': 15.1.6 - '@next/swc-win32-x64-msvc': 15.1.6 - sharp: 0.33.5 - transitivePeerDependencies: - - '@babel/core' - - babel-plugin-macros node-int64@0.4.0: {} @@ -9885,11 +9877,6 @@ snapshots: react: 18.3.1 scheduler: 0.23.2 - react-dom@19.0.0(react@19.0.0): - dependencies: - react: 19.0.0 - scheduler: 0.25.0 - react-is@16.13.1: {} react-is@18.3.1: {} @@ -9912,8 +9899,6 @@ snapshots: dependencies: loose-envify: 1.4.0 - react@19.0.0: {} - readable-stream@2.3.8: dependencies: core-util-is: 1.0.3 @@ -10109,8 +10094,6 @@ snapshots: dependencies: loose-envify: 1.4.0 - scheduler@0.25.0: {} - semver@6.3.1: {} semver@7.6.3: {} @@ -10424,12 +10407,6 @@ snapshots: react: 18.3.1 optionalDependencies: '@babel/core': 7.26.7 - optional: true - - styled-jsx@5.1.6(react@19.0.0): - dependencies: - client-only: 0.0.1 - react: 19.0.0 sucrase@3.35.0: dependencies: @@ -10561,7 +10538,7 @@ snapshots: ts-interface-checker@0.1.13: {} - ts-jest@29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0)(typescript@5.7.3): + ts-jest@29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0(@types/node@22.10.10))(typescript@5.7.3): dependencies: bs-logger: 0.2.6 ejs: 3.1.10 @@ -10893,16 +10870,6 @@ snapshots: '@types/node': 22.10.10 fsevents: 2.3.3 - vite@6.0.11(@types/node@22.10.10)(yaml@2.7.0): - dependencies: - esbuild: 0.24.2 - postcss: 8.5.1 - rollup: 4.32.0 - optionalDependencies: - '@types/node': 22.10.10 - fsevents: 2.3.3 - yaml: 2.7.0 - w3c-xmlserializer@4.0.0: dependencies: xml-name-validator: 4.0.0 diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 473cce298cb2c..07ef608b05364 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -37,7 +37,7 @@ fi # All examples implement these two tasks # and it's reasonable to assume that they will continue to do so -turbo_command="turbo build && turbo lint && turbo check-types --continue --output-logs=errors-only" +turbo_command="turbo build lint check-types --continue --output-logs=errors-only" # Head into a temporary directory mkdir -p ../../examples-tests-tmp From a59dfc9b86205c5165f8ef07ead49b39ee2139fd Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 21:46:18 -0700 Subject: [PATCH 04/17] WIP --- examples/kitchen-sink/apps/api/package.json | 7 +------ .../kitchen-sink/packages/config-eslint/package.json | 6 ------ .../kitchen-sink/packages/config-typescript/package.json | 9 --------- examples/kitchen-sink/packages/jest-presets/package.json | 9 ++------- examples/kitchen-sink/packages/logger/package.json | 7 ------- examples/kitchen-sink/packages/ui/package.json | 3 --- 6 files changed, 3 insertions(+), 38 deletions(-) diff --git a/examples/kitchen-sink/apps/api/package.json b/examples/kitchen-sink/apps/api/package.json index 3ce000ef9c2bd..a9fad1d0ee7aa 100644 --- a/examples/kitchen-sink/apps/api/package.json +++ b/examples/kitchen-sink/apps/api/package.json @@ -19,9 +19,7 @@ "body-parser": "^1.20.3", "cors": "^2.8.5", "express": "^5.0.1", - "morgan": "^1.10.0", - "react": "^18.2.0", - "vite": "^5.4.14" + "morgan": "^1.10.0" }, "devDependencies": { "@jest/globals": "^29.7.0", @@ -33,11 +31,8 @@ "@types/express": "4.17.17", "@types/morgan": "^1.9.9", "@types/node": "^22.10.10", - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", "@types/supertest": "^6.0.2", "jest": "^29.7.0", - "react-dom": "^18.2.0", "supertest": "^7.0.0", "tsup": "^8.3.6", "typescript": "5.7.3" diff --git a/examples/kitchen-sink/packages/config-eslint/package.json b/examples/kitchen-sink/packages/config-eslint/package.json index 531722d5417df..7cefd2fb2bf9e 100644 --- a/examples/kitchen-sink/packages/config-eslint/package.json +++ b/examples/kitchen-sink/packages/config-eslint/package.json @@ -13,8 +13,6 @@ "devDependencies": { "@eslint/js": "^9.19.0", "@next/eslint-plugin-next": "^15.1.6", - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", "eslint": "^9.19.0", "eslint-config-prettier": "^10.0.1", "eslint-plugin-only-warn": "^1.1.0", @@ -25,9 +23,5 @@ "react-dom": "^18.2.0", "typescript": "^5.7.3", "typescript-eslint": "^8.22.0" - }, - "dependencies": { - "react": "^18.2.0", - "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/packages/config-typescript/package.json b/examples/kitchen-sink/packages/config-typescript/package.json index f31ce631e7c5b..27c0e60436aac 100644 --- a/examples/kitchen-sink/packages/config-typescript/package.json +++ b/examples/kitchen-sink/packages/config-typescript/package.json @@ -5,14 +5,5 @@ "license": "MIT", "publishConfig": { "access": "public" - }, - "dependencies": { - "react": "^18.2.0", - "vite": "^5.4.14" - }, - "devDependencies": { - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", - "react-dom": "^18.2.0" } } diff --git a/examples/kitchen-sink/packages/jest-presets/package.json b/examples/kitchen-sink/packages/jest-presets/package.json index e82a2b934b54e..e6567cc7dcd1b 100644 --- a/examples/kitchen-sink/packages/jest-presets/package.json +++ b/examples/kitchen-sink/packages/jest-presets/package.json @@ -9,14 +9,9 @@ ], "dependencies": { "jest": "^29.7.0", - "react": "^18.2.0", - "ts-jest": "^29.2.5", - "vite": "^5.4.14" + "ts-jest": "^29.2.5" }, "devDependencies": { - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", - "jest-environment-jsdom": "^29.7.0", - "react-dom": "^18.2.0" + "jest-environment-jsdom": "^29.7.0" } } diff --git a/examples/kitchen-sink/packages/logger/package.json b/examples/kitchen-sink/packages/logger/package.json index 52b79dfd63db8..1c26a2d7b75c6 100644 --- a/examples/kitchen-sink/packages/logger/package.json +++ b/examples/kitchen-sink/packages/logger/package.json @@ -24,16 +24,9 @@ "@repo/jest-presets": "workspace:*", "@repo/typescript-config": "workspace:*", "@types/node": "^22.10.10", - "@types/react": "^18.2.20", - "@types/react-dom": "^18.2.7", "eslint": "^9.19.0", "jest": "^29.7.0", - "react-dom": "^18.2.0", "tsup": "^8.3.6", "typescript": "5.7.3" - }, - "dependencies": { - "react": "^18.2.0", - "vite": "^5.4.14" } } diff --git a/examples/kitchen-sink/packages/ui/package.json b/examples/kitchen-sink/packages/ui/package.json index d3cdcc6a5a51d..72eecd75a6e16 100644 --- a/examples/kitchen-sink/packages/ui/package.json +++ b/examples/kitchen-sink/packages/ui/package.json @@ -42,8 +42,5 @@ "react-dom": "^18.3.1", "tsup": "^8.3.6", "typescript": "5.7.3" - }, - "dependencies": { - "vite": "^5.4.14" } } From 8d7ac8639498c81606b93a448c9df56a4d1dd305 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 21:52:59 -0700 Subject: [PATCH 05/17] WIP --- .github/dependabot.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index f199bfe6d1cd4..6ead4ba303abb 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -49,6 +49,8 @@ updates: - dependency-name: "react-dom" - dependency-name: "@types/react" - dependency-name: "@types/react-dom" + # We can't upgrade versions of this due to npm + - dependency-name: "vite" - package-ecosystem: "npm" directory: "/examples/non-monorepo" From cbdd389178a54a2371f7473d18aacf9be90f4e4f Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 21:56:23 -0700 Subject: [PATCH 06/17] WIP --- examples/kitchen-sink/pnpm-lock.yaml | 86 +--------------------------- 1 file changed, 3 insertions(+), 83 deletions(-) diff --git a/examples/kitchen-sink/pnpm-lock.yaml b/examples/kitchen-sink/pnpm-lock.yaml index 1677708f03198..184a85f50a018 100644 --- a/examples/kitchen-sink/pnpm-lock.yaml +++ b/examples/kitchen-sink/pnpm-lock.yaml @@ -66,12 +66,6 @@ importers: morgan: specifier: ^1.10.0 version: 1.10.0 - react: - specifier: ^18.2.0 - version: 18.3.1 - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -100,21 +94,12 @@ importers: '@types/node': specifier: ^22.10.10 version: 22.10.10 - '@types/react': - specifier: ^18.2.20 - version: 18.3.18 - '@types/react-dom': - specifier: ^18.2.7 - version: 18.3.5(@types/react@18.3.18) '@types/supertest': specifier: ^6.0.2 version: 6.0.2 jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) - react-dom: - specifier: ^18.2.0 - version: 18.3.1(react@18.3.1) supertest: specifier: ^7.0.0 version: 7.0.0 @@ -230,13 +215,6 @@ importers: version: 5.7.3 packages/config-eslint: - dependencies: - react: - specifier: ^18.2.0 - version: 18.3.1 - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) devDependencies: '@eslint/js': specifier: ^9.19.0 @@ -244,12 +222,6 @@ importers: '@next/eslint-plugin-next': specifier: ^15.1.6 version: 15.1.6 - '@types/react': - specifier: ^18.2.20 - version: 18.3.18 - '@types/react-dom': - specifier: ^18.2.7 - version: 18.3.5(@types/react@18.3.18) eslint: specifier: ^9.19.0 version: 9.19.0 @@ -281,61 +253,22 @@ importers: specifier: ^8.22.0 version: 8.22.0(eslint@9.19.0)(typescript@5.7.3) - packages/config-typescript: - dependencies: - react: - specifier: ^18.2.0 - version: 18.3.1 - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) - devDependencies: - '@types/react': - specifier: ^18.2.20 - version: 18.3.18 - '@types/react-dom': - specifier: ^18.2.7 - version: 18.3.5(@types/react@18.3.18) - react-dom: - specifier: ^18.2.0 - version: 18.3.1(react@18.3.1) + packages/config-typescript: {} packages/jest-presets: dependencies: jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) - react: - specifier: ^18.2.0 - version: 18.3.1 ts-jest: specifier: ^29.2.5 - version: 29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0(@types/node@22.10.10))(typescript@5.7.3) - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) + version: 29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0)(typescript@5.7.3) devDependencies: - '@types/react': - specifier: ^18.2.20 - version: 18.3.18 - '@types/react-dom': - specifier: ^18.2.7 - version: 18.3.5(@types/react@18.3.18) jest-environment-jsdom: specifier: ^29.7.0 version: 29.7.0 - react-dom: - specifier: ^18.2.0 - version: 18.3.1(react@18.3.1) packages/logger: - dependencies: - react: - specifier: ^18.2.0 - version: 18.3.1 - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -352,21 +285,12 @@ importers: '@types/node': specifier: ^22.10.10 version: 22.10.10 - '@types/react': - specifier: ^18.2.20 - version: 18.3.18 - '@types/react-dom': - specifier: ^18.2.7 - version: 18.3.5(@types/react@18.3.18) eslint: specifier: ^9.19.0 version: 9.19.0 jest: specifier: ^29.7.0 version: 29.7.0(@types/node@22.10.10) - react-dom: - specifier: ^18.2.0 - version: 18.3.1(react@18.3.1) tsup: specifier: ^8.3.6 version: 8.3.6(postcss@8.5.1)(typescript@5.7.3)(yaml@2.7.0) @@ -375,10 +299,6 @@ importers: version: 5.7.3 packages/ui: - dependencies: - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) devDependencies: '@jest/globals': specifier: ^29.7.0 @@ -10538,7 +10458,7 @@ snapshots: ts-interface-checker@0.1.13: {} - ts-jest@29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0(@types/node@22.10.10))(typescript@5.7.3): + ts-jest@29.2.5(@babel/core@7.26.7)(@jest/transform@29.7.0)(@jest/types@29.6.3)(babel-jest@29.7.0(@babel/core@7.26.7))(jest@29.7.0)(typescript@5.7.3): dependencies: bs-logger: 0.2.6 ejs: 3.1.10 From 957b1f8ed8e765050a13c319f4da1b07f84e8199 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:02:20 -0700 Subject: [PATCH 07/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 07ef608b05364..263d3bd53a232 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -37,7 +37,7 @@ fi # All examples implement these two tasks # and it's reasonable to assume that they will continue to do so -turbo_command="turbo build lint check-types --continue --output-logs=errors-only" +turbo_command="turbo build lint check-types --continue --output-logs=errors-only --concurrency=1" # Head into a temporary directory mkdir -p ../../examples-tests-tmp From ce26e47ccc4885d6933c43e4e881c0a5b24cae7f Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:06:07 -0700 Subject: [PATCH 08/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 263d3bd53a232..63f38b6c1511d 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -37,7 +37,7 @@ fi # All examples implement these two tasks # and it's reasonable to assume that they will continue to do so -turbo_command="turbo build lint check-types --continue --output-logs=errors-only --concurrency=1" +turbo_command="turbo build lint --continue --output-logs=errors-only" # Head into a temporary directory mkdir -p ../../examples-tests-tmp From 7d3fa632175060f2fa8e50c5e7e68f217b192267 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:08:02 -0700 Subject: [PATCH 09/17] WIP --- examples/with-svelte/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/with-svelte/README.md b/examples/with-svelte/README.md index 016d2adf01ffb..665eb99e1c7da 100644 --- a/examples/with-svelte/README.md +++ b/examples/with-svelte/README.md @@ -1,3 +1,5 @@ +test + # Turborepo Svelte starter This Turborepo starter is maintained by the Turborepo core team. From 6b13614a6e3dd61e9a39cb604963f8d6b99b0046 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:13:58 -0700 Subject: [PATCH 10/17] WIP --- examples/with-svelte/README.md | 2 -- turborepo-tests/helpers/setup_example_test.sh | 11 +++++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/examples/with-svelte/README.md b/examples/with-svelte/README.md index 665eb99e1c7da..016d2adf01ffb 100644 --- a/examples/with-svelte/README.md +++ b/examples/with-svelte/README.md @@ -1,5 +1,3 @@ -test - # Turborepo Svelte starter This Turborepo starter is maintained by the Turborepo core team. diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 63f38b6c1511d..96e4fa1aa3923 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -35,9 +35,12 @@ if [ "$package_manager" == "pnpm" ] && [ "$example_path" == "non-monorepo" ]; th package_manager_command="pnpm install --ignore-workspace" fi -# All examples implement these two tasks -# and it's reasonable to assume that they will continue to do so -turbo_command="turbo build lint --continue --output-logs=errors-only" +# with-svelte is flaky when building and check types at the same time, because the build process of Svelte involves type generation +if ["$example_path" == "with-svelte"]; then + turbo_command="turbo build lint --continue --output-logs=errors-only" +elif + turbo_command="turbo build lint check-types --continue --output-logs=errors-only" +fi # Head into a temporary directory mkdir -p ../../examples-tests-tmp @@ -50,7 +53,7 @@ rsync -avq \ --exclude="dist" \ --exclude=".turbo" \ --exclude=".expo" \ - --exclude=".cache" \ +--exclude=".cache" \ --exclude=".next" \ "../examples/$example_path" "$example_path-$package_manager" From 3e4427355b07b869a4ca727828ce0e4fb9324dcd Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:15:05 -0700 Subject: [PATCH 11/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 96e4fa1aa3923..27bbad827c815 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -36,9 +36,12 @@ if [ "$package_manager" == "pnpm" ] && [ "$example_path" == "non-monorepo" ]; th fi # with-svelte is flaky when building and check types at the same time, because the build process of Svelte involves type generation +# If the types are generating while the type checking happens, it can cause flakes. +# We'll have to accept this gap in our coverage. if ["$example_path" == "with-svelte"]; then turbo_command="turbo build lint --continue --output-logs=errors-only" elif +# The rest of the examples implement these three tasks and look safe to test in parallel turbo_command="turbo build lint check-types --continue --output-logs=errors-only" fi From 4fd8371b0d677584b2d12158053465ad286f6fa6 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:18:22 -0700 Subject: [PATCH 12/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index 27bbad827c815..d95470e709852 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -40,8 +40,8 @@ fi # We'll have to accept this gap in our coverage. if ["$example_path" == "with-svelte"]; then turbo_command="turbo build lint --continue --output-logs=errors-only" -elif -# The rest of the examples implement these three tasks and look safe to test in parallel +else + # The rest of the examples implement these three tasks and look safe to test in parallel turbo_command="turbo build lint check-types --continue --output-logs=errors-only" fi @@ -56,7 +56,7 @@ rsync -avq \ --exclude="dist" \ --exclude=".turbo" \ --exclude=".expo" \ ---exclude=".cache" \ + --exclude=".cache" \ --exclude=".next" \ "../examples/$example_path" "$example_path-$package_manager" From df025c007fed1211685eb156c73ebfd64c39a999 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:23:16 -0700 Subject: [PATCH 13/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index d95470e709852..b8e9518a8dcf7 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -35,10 +35,12 @@ if [ "$package_manager" == "pnpm" ] && [ "$example_path" == "non-monorepo" ]; th package_manager_command="pnpm install --ignore-workspace" fi +echo $example_path + # with-svelte is flaky when building and check types at the same time, because the build process of Svelte involves type generation # If the types are generating while the type checking happens, it can cause flakes. # We'll have to accept this gap in our coverage. -if ["$example_path" == "with-svelte"]; then +if [ "$example_path" == "with-svelte" ]; then turbo_command="turbo build lint --continue --output-logs=errors-only" else # The rest of the examples implement these three tasks and look safe to test in parallel From 4e224faf0d8aabdd6e4ea47bdfaeea39e90ee977 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:23:24 -0700 Subject: [PATCH 14/17] WIP --- turborepo-tests/helpers/setup_example_test.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/turborepo-tests/helpers/setup_example_test.sh b/turborepo-tests/helpers/setup_example_test.sh index b8e9518a8dcf7..2087c425f5062 100644 --- a/turborepo-tests/helpers/setup_example_test.sh +++ b/turborepo-tests/helpers/setup_example_test.sh @@ -35,8 +35,6 @@ if [ "$package_manager" == "pnpm" ] && [ "$example_path" == "non-monorepo" ]; th package_manager_command="pnpm install --ignore-workspace" fi -echo $example_path - # with-svelte is flaky when building and check types at the same time, because the build process of Svelte involves type generation # If the types are generating while the type checking happens, it can cause flakes. # We'll have to accept this gap in our coverage. From 05d855ebc4ce3a11aec0422eabb1c47f7a7f650d Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:28:54 -0700 Subject: [PATCH 15/17] WIP --- examples/kitchen-sink/apps/admin/package.json | 4 ++-- examples/kitchen-sink/apps/storefront/package.json | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/kitchen-sink/apps/admin/package.json b/examples/kitchen-sink/apps/admin/package.json index 575b929eb78a2..67e49b4c4f4ad 100644 --- a/examples/kitchen-sink/apps/admin/package.json +++ b/examples/kitchen-sink/apps/admin/package.json @@ -11,7 +11,8 @@ }, "dependencies": { "@repo/ui": "workspace:*", - "react": "^18.3.1" + "react": "^18.3.1", + "react-dom": "^18.3.1" }, "devDependencies": { "@repo/eslint-config": "workspace:*", @@ -19,7 +20,6 @@ "@types/react": "^18.3.18", "@types/react-dom": "^18.3.5", "@vitejs/plugin-react": "^4.3.4", - "react-dom": "^18.3.1", "typescript": "5.7.3", "vite": "^5.4.14" } diff --git a/examples/kitchen-sink/apps/storefront/package.json b/examples/kitchen-sink/apps/storefront/package.json index 4c16e0c602fc0..9b82baeef867f 100644 --- a/examples/kitchen-sink/apps/storefront/package.json +++ b/examples/kitchen-sink/apps/storefront/package.json @@ -15,7 +15,7 @@ "@repo/ui": "workspace:*", "next": "^15.1.6", "react": "^18.3.1", - "vite": "^5.4.14" + "react-dom": "^18.3.1" }, "devDependencies": { "@next/eslint-plugin-next": "^15.1.6", @@ -24,7 +24,6 @@ "@types/node": "^22.10.10", "@types/react": "^18.3.18", "@types/react-dom": "^18.3.5", - "react-dom": "^18.3.1", "typescript": "5.7.3" } } From f35424a13971cc4214b7921297854defa30f8f60 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:29:30 -0700 Subject: [PATCH 16/17] WIP --- examples/kitchen-sink/packages/config-eslint/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/kitchen-sink/packages/config-eslint/package.json b/examples/kitchen-sink/packages/config-eslint/package.json index 7cefd2fb2bf9e..784c9e55bc314 100644 --- a/examples/kitchen-sink/packages/config-eslint/package.json +++ b/examples/kitchen-sink/packages/config-eslint/package.json @@ -20,7 +20,6 @@ "eslint-plugin-react-hooks": "^5.1.0", "eslint-plugin-turbo": "^2.3.4", "globals": "^15.14.0", - "react-dom": "^18.2.0", "typescript": "^5.7.3", "typescript-eslint": "^8.22.0" } From 4d037d54858e7beb2b57f0084398e6052d75b30a Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 28 Jan 2025 22:30:17 -0700 Subject: [PATCH 17/17] WIP --- examples/kitchen-sink/pnpm-lock.yaml | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/examples/kitchen-sink/pnpm-lock.yaml b/examples/kitchen-sink/pnpm-lock.yaml index 184a85f50a018..199118c773475 100644 --- a/examples/kitchen-sink/pnpm-lock.yaml +++ b/examples/kitchen-sink/pnpm-lock.yaml @@ -23,6 +23,9 @@ importers: react: specifier: ^18.3.1 version: 18.3.1 + react-dom: + specifier: ^18.3.1 + version: 18.3.1(react@18.3.1) devDependencies: '@repo/eslint-config': specifier: workspace:* @@ -39,9 +42,6 @@ importers: '@vitejs/plugin-react': specifier: ^4.3.4 version: 4.3.4(vite@5.4.14(@types/node@22.10.10)) - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) typescript: specifier: 5.7.3 version: 5.7.3 @@ -185,9 +185,9 @@ importers: react: specifier: ^18.3.1 version: 18.3.1 - vite: - specifier: ^5.4.14 - version: 5.4.14(@types/node@22.10.10) + react-dom: + specifier: ^18.3.1 + version: 18.3.1(react@18.3.1) devDependencies: '@next/eslint-plugin-next': specifier: ^15.1.6 @@ -207,9 +207,6 @@ importers: '@types/react-dom': specifier: ^18.3.5 version: 18.3.5(@types/react@18.3.18) - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) typescript: specifier: 5.7.3 version: 5.7.3 @@ -243,9 +240,6 @@ importers: globals: specifier: ^15.14.0 version: 15.14.0 - react-dom: - specifier: ^18.2.0 - version: 18.3.1(react@18.3.1) typescript: specifier: ^5.7.3 version: 5.7.3