From 4ea903fd175f7d4610550803f044b01f80b86fce Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:02:53 -0700 Subject: [PATCH 1/8] testing --- .github/workflows/turborepo-test.yml | 29 ++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index c53a3c3895842..2f49c6718c482 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -36,20 +36,20 @@ jobs: examples-utils: - "turborepo-tests/helpers/**" basic-example: - - examples/basic/** - - turborepo-tests/example-basic-*/** + - "examples/basic/**" + - "turborepo-tests/example-basic-*/**" kitchen-sink-example: - - examples/kitchen-sink/** - - turborepo-tests/example-kitchen-sink-*/** + - "examples/kitchen-sink/**" + - "turborepo-tests/example-kitchen-sink-*/**" non-monorepo-example: - - examples/non-monorepo/** - - turborepo-tests/example-non-monorepo-*/** + - "examples/non-monorepo/**" + - "turborepo-tests/example-non-monorepo-*/**" with-svelte-example: - - examples/with-svelte/** - - turborepo-tests/example-with-svelte-*/** + - "examples/with-svelte/**" + - "turborepo-tests/example-with-svelte-*/**" with-tailwind-example: - - examples/with-tailwind/** - - turborepo-tests/example-with-svelte-*/** + - "examples/with-tailwind/**" + - "turborepo-tests/example-with-svelte-*/**" rest: - "!examples/**" - "!docs/**" @@ -123,6 +123,15 @@ jobs: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + echo: + name: echo + needs: find-changes + runs-on: ubuntu-latest + steps: + - name: echo + run: | + echo ${{ needs.find-changes.outputs }} + rust_lint: name: Rust lints needs: From cc34483f036a4c99581047502335879d1962e662 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:04:58 -0700 Subject: [PATCH 2/8] WIP --- .github/workflows/turborepo-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index 2f49c6718c482..5c97e4352e0b7 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -130,7 +130,7 @@ jobs: steps: - name: echo run: | - echo ${{ needs.find-changes.outputs }} + echo ${{ fromJson(needs.find-changes.outputs) }} rust_lint: name: Rust lints From f5c2a990c52e901938a52bd57fba24a0038a0d48 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:08:19 -0700 Subject: [PATCH 3/8] WIP --- .github/workflows/turborepo-test.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index 5c97e4352e0b7..f5a2d758d2ef1 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -123,15 +123,6 @@ jobs: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - echo: - name: echo - needs: find-changes - runs-on: ubuntu-latest - steps: - - name: echo - run: | - echo ${{ fromJson(needs.find-changes.outputs) }} - rust_lint: name: Rust lints needs: @@ -259,6 +250,8 @@ jobs: basic-example: name: "`basic` example" timeout-minutes: 40 + needs: + - find-changes if: ${{ needs.find-changes.outputs.basic-example == 'true' }} runs-on: ubuntu-latest steps: @@ -275,6 +268,8 @@ jobs: kitchen-sink-example: name: "`kitchen-sink` example" + needs: + - find-changes timeout-minutes: 40 if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} runs-on: ubuntu-latest @@ -293,6 +288,8 @@ jobs: non-monorepo-example: name: "`non-monorepo` example" timeout-minutes: 40 + needs: + - find-changes if: ${{ needs.find-changes.outputs.non-monorepo-example == 'true' }} runs-on: ubuntu-latest steps: @@ -310,6 +307,8 @@ jobs: with-svelte-example: name: "`with-svelte` example" timeout-minutes: 40 + needs: + - find-changes if: ${{ needs.find-changes.outputs.with-svelte-example == 'true' }} runs-on: ubuntu-latest steps: @@ -327,6 +326,8 @@ jobs: with-tailwind-example: name: "`with-tailwind` example" timeout-minutes: 40 + needs: + - find-changes if: ${{ needs.find-changes.outputs.with-tailwind-example == 'true' }} runs-on: ubuntu-latest steps: From ddee6e27288fb4df8df22b584103627c11db365a Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:14:34 -0700 Subject: [PATCH 4/8] WIP --- .github/workflows/turborepo-test.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index f5a2d758d2ef1..8d2b2662cfbd1 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -51,6 +51,7 @@ jobs: - "examples/with-tailwind/**" - "turborepo-tests/example-with-svelte-*/**" rest: + - "**" - "!examples/**" - "!docs/**" @@ -252,7 +253,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.basic-example == 'true' }} + if: ${{ needs.find-changes.outputs.basic-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -271,7 +272,7 @@ jobs: needs: - find-changes timeout-minutes: 40 - if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} + if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -290,7 +291,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.non-monorepo-example == 'true' }} + if: ${{ needs.find-changes.outputs.non-monorepo-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -309,7 +310,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.with-svelte-example == 'true' }} + if: ${{ needs.find-changes.outputs.with-svelte-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -328,7 +329,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.with-tailwind-example == 'true' }} + if: ${{ needs.find-changes.outputs.with-tailwind-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout From ce2c5304c42c05a9f015509229f145de1c528ac9 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:20:33 -0700 Subject: [PATCH 5/8] WIP --- .github/workflows/turborepo-test.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index 8d2b2662cfbd1..65b08223084d1 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -51,9 +51,7 @@ jobs: - "examples/with-tailwind/**" - "turborepo-tests/example-with-svelte-*/**" rest: - - "**" - - "!examples/**" - - "!docs/**" + - '!(examples/**|docs/**)' integration: name: Turborepo Integration From 7d2ab1da7a8aeec8100d156fd68c7951ea3594ab Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:41:09 -0700 Subject: [PATCH 6/8] ci: still trying to get paths right --- .github/workflows/turborepo-test.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index 65b08223084d1..ccdd55ed08cb8 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -19,7 +19,6 @@ jobs: runs-on: ubuntu-latest outputs: docs: ${{ steps.filter.outputs.docs }} - examples-utils: ${{ steps.filter.outputs.examples-utils }} basic-example: ${{ steps.filter.outputs.basic-example }} kitchen-sink-example: ${{ steps.filter.outputs.kitchen-sink-example }} non-monorepo-example: ${{ steps.filter.outputs.non-monorepo-example }} @@ -33,23 +32,26 @@ jobs: filters: | docs: - "docs/**" - examples-utils: - - "turborepo-tests/helpers/**" basic-example: - "examples/basic/**" - "turborepo-tests/example-basic-*/**" + - "turborepo-tests/helpers/**" kitchen-sink-example: - "examples/kitchen-sink/**" - "turborepo-tests/example-kitchen-sink-*/**" + - "turborepo-tests/helpers/**" non-monorepo-example: - "examples/non-monorepo/**" - "turborepo-tests/example-non-monorepo-*/**" + - "turborepo-tests/helpers/**" with-svelte-example: - "examples/with-svelte/**" - "turborepo-tests/example-with-svelte-*/**" + - "turborepo-tests/helpers/**" with-tailwind-example: - "examples/with-tailwind/**" - "turborepo-tests/example-with-svelte-*/**" + - "turborepo-tests/helpers/**" rest: - '!(examples/**|docs/**)' @@ -251,7 +253,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.basic-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.basic-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -270,7 +272,7 @@ jobs: needs: - find-changes timeout-minutes: 40 - if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -289,7 +291,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.non-monorepo-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.non-monorepo-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -308,7 +310,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.with-svelte-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.with-svelte-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout @@ -327,7 +329,7 @@ jobs: timeout-minutes: 40 needs: - find-changes - if: ${{ needs.find-changes.outputs.with-tailwind-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.with-tailwind-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout From 6b2421cb97215e8658c8bc228b53b4d762d66bc9 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 15:47:27 -0700 Subject: [PATCH 7/8] WIP --- .github/workflows/turborepo-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index 66f7df1349c1f..ccdd55ed08cb8 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -272,7 +272,7 @@ jobs: needs: - find-changes timeout-minutes: 40 - if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} || ${{ needs.find-changes.outputs.examples-utils == 'true' }} + if: ${{ needs.find-changes.outputs.kitchen-sink-example == 'true' }} runs-on: ubuntu-latest steps: - name: Checkout From 1a5f93381a784ac445aa9ffb3648a8687b84bba7 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Thu, 23 Jan 2025 16:09:18 -0700 Subject: [PATCH 8/8] ci: still trying to get paths right --- .github/workflows/turborepo-test.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml index ccdd55ed08cb8..a3e0c31a36904 100644 --- a/.github/workflows/turborepo-test.yml +++ b/.github/workflows/turborepo-test.yml @@ -53,7 +53,9 @@ jobs: - "turborepo-tests/example-with-svelte-*/**" - "turborepo-tests/helpers/**" rest: - - '!(examples/**|docs/**)' + - '!examples/**' + - '!docs/**' + - '**' integration: name: Turborepo Integration