From 15b91e720d00689622d642844b5306f5170ff164 Mon Sep 17 00:00:00 2001 From: Jared Palmer Date: Thu, 10 Mar 2022 09:57:26 -0500 Subject: [PATCH 1/2] Remove `packageManager` warning --- cli/internal/backends/nodejs/nodejs.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cli/internal/backends/nodejs/nodejs.go b/cli/internal/backends/nodejs/nodejs.go index 8cd1c16b3e49d..b3615675e424d 100644 --- a/cli/internal/backends/nodejs/nodejs.go +++ b/cli/internal/backends/nodejs/nodejs.go @@ -3,7 +3,6 @@ package nodejs import ( "fmt" "io/ioutil" - "log" "path/filepath" "github.com/vercel/turborepo/cli/internal/api" @@ -58,7 +57,7 @@ var NodejsYarnBackend = api.LanguageBackend{ return true, nil } } else { - log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please run \"npx @turbo/codemod add-package-manager\"") + // log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please run \"npx @turbo/codemod add-package-manager\"") specfileExists := fs.FileExists(filepath.Join(cwd, backend.Specfile)) lockfileExists := fs.FileExists(filepath.Join(cwd, backend.Lockfile)) @@ -118,7 +117,6 @@ var NodejsBerryBackend = api.LanguageBackend{ return true, nil } } else { - log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please set the \"packageManager\" field to your package.json") specfileExists := fs.FileExists(filepath.Join(cwd, backend.Specfile)) lockfileExists := fs.FileExists(filepath.Join(cwd, backend.Lockfile)) @@ -187,7 +185,6 @@ var NodejsPnpmBackend = api.LanguageBackend{ return true, nil } } else { - log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please run \"npx @turbo/codemod add-package-manager\"") specfileExists := fs.FileExists(filepath.Join(cwd, backend.Specfile)) lockfileExists := fs.FileExists(filepath.Join(cwd, backend.Lockfile)) @@ -232,7 +229,6 @@ var NodejsNpmBackend = api.LanguageBackend{ return true, nil } } else { - log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please run \"npx @turbo/codemod add-package-manager\"") specfileExists := fs.FileExists(filepath.Join(cwd, backend.Specfile)) lockfileExists := fs.FileExists(filepath.Join(cwd, backend.Lockfile)) From 3e599c1c658590e5b88959b37d68c3943358a1ab Mon Sep 17 00:00:00 2001 From: Greg Soltis Date: Thu, 10 Mar 2022 09:01:48 -0800 Subject: [PATCH 2/2] Update nodejs.go Remove commented-out log line. --- cli/internal/backends/nodejs/nodejs.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cli/internal/backends/nodejs/nodejs.go b/cli/internal/backends/nodejs/nodejs.go index b3615675e424d..1c8cff76f143e 100644 --- a/cli/internal/backends/nodejs/nodejs.go +++ b/cli/internal/backends/nodejs/nodejs.go @@ -57,8 +57,6 @@ var NodejsYarnBackend = api.LanguageBackend{ return true, nil } } else { - // log.Println("[WARNING] Did not find \"packageManager\" in your package.json. Please run \"npx @turbo/codemod add-package-manager\"") - specfileExists := fs.FileExists(filepath.Join(cwd, backend.Specfile)) lockfileExists := fs.FileExists(filepath.Join(cwd, backend.Lockfile))