fix(lockfile): Fix directory resolution variant #5551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Contributor
🟢 CI successful 🟢Thanks |
NicholasLYang
approved these changes
Jul 18, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5529
During the Rust migration I must've messed up the directory field name. Double checked against
@pnpm/lockfile-typesto make sure all of the fields are correct now.PackageResolutionshould be an enum, but the fact that tarballs are an untagged variant makes that tricky to communicate toserde. A struct does enough for us.Testing Instructions
Added new unit test to make sure we don't lose any fields for the various variants of the
resolutionfield