这是indexloc提供的服务,不要输入任何密码
Skip to content

feat(ecmascript): support configurable emotion options #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 5, 2023

Reverts #4481

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-tailwind-web 🔄 Building (Inspect) Apr 11, 2023 6:43pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 6:43pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-native-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 11, 2023 6:43pm

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

✅ This changes can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

🟢 CI successful 🟢

Thanks

@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch from 87fb5f4 to 6bf4982 Compare April 6, 2023 17:50
@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch 3 times, most recently from 13830ac to e32c713 Compare April 6, 2023 18:33
@kwonoj kwonoj marked this pull request as ready for review April 6, 2023 19:25
@kwonoj kwonoj requested a review from a team as a code owner April 6, 2023 19:25
@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch from e32c713 to fb03487 Compare April 10, 2023 16:16
@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch from fb03487 to 8261d4f Compare April 11, 2023 16:14
@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch from 8261d4f to e22b96e Compare April 11, 2023 18:40
@kwonoj kwonoj force-pushed the revert-4481-revert-4458-feat-emotion-options branch from e22b96e to f30f35c Compare April 11, 2023 18:42
@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 12, 2023
@kodiakhq kodiakhq bot merged commit 5f8ba5e into main Apr 12, 2023
@kodiakhq kodiakhq bot deleted the revert-4481-revert-4458-feat-emotion-options branch April 12, 2023 16:03
sokra pushed a commit to vercel/next.js that referenced this pull request Apr 12, 2023
…mponents flag (#47991)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation or adding/fixing Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md



## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### Why?

### How?

Closes NEXT-
Fixes #

-->

### What?

Related with WEB-669 and initial support for
[WEB-670](https://linear.app/vercel/issue/WEB-670), allows to consume
compiler.emotion with latest turbopack.

I was trying to make additional changes to make test fully pass, but
there are some other failures around so this change cannot able to pass
existing tests yet.

Turbopack changes: vercel/turborepo#4482
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants