From 34473d2d06689431a4732c7d5783a925dbeefda9 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Sat, 20 Sep 2025 20:02:05 -0600 Subject: [PATCH 1/2] fix: add WINDIR to deafult passthroughs --- crates/turborepo-lib/src/task_hash.rs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/crates/turborepo-lib/src/task_hash.rs b/crates/turborepo-lib/src/task_hash.rs index fcf82ffd936da..184670fe245cf 100644 --- a/crates/turborepo-lib/src/task_hash.rs +++ b/crates/turborepo-lib/src/task_hash.rs @@ -6,25 +6,25 @@ use std::{ use rayon::prelude::*; use serde::Serialize; use thiserror::Error; -use tracing::{debug, Span}; +use tracing::{Span, debug}; use turbopath::{AbsoluteSystemPath, AnchoredSystemPath, AnchoredSystemPathBuf}; use turborepo_cache::CacheHitMetadata; use turborepo_env::{BySource, DetailedMap, EnvironmentVariableMap}; -use turborepo_frameworks::{infer_framework, Slug as FrameworkSlug}; +use turborepo_frameworks::{Slug as FrameworkSlug, infer_framework}; use turborepo_repository::package_graph::{PackageInfo, PackageName}; use turborepo_scm::SCM; use turborepo_task_id::TaskId; use turborepo_telemetry::events::{ - generic::GenericEventBuilder, task::PackageTaskEventBuilder, EventBuilder, + EventBuilder, generic::GenericEventBuilder, task::PackageTaskEventBuilder, }; use crate::{ + DaemonClient, DaemonConnector, cli::EnvMode, engine::TaskNode, hash::{FileHashes, LockFilePackages, TaskHashable, TurboHash}, opts::RunOpts, task_graph::TaskDefinition, - DaemonClient, DaemonConnector, }; #[derive(Debug, Error)] @@ -149,9 +149,9 @@ impl PackageInputsHashes { ); }) .ok() // If we timed out, we don't need to - // error, - // just return None so we can move on to - // local + // error, + // just return None so we can move on to + // local }) .and_then(|result| { match result { @@ -456,6 +456,8 @@ impl<'a> TaskHasher<'a> { "DISPLAY", "TMP", "TEMP", + // Windows + "WINDIR", // VSCode IDE - https://github.com/microsoft/vscode-js-debug/blob/5b0f41dbe845d693a541c1fae30cec04c878216f/src/targets/node/nodeLauncherBase.ts#L320 "VSCODE_*", "ELECTRON_RUN_AS_NODE", From 9a84cc32aa4e4ca0680e2ed7243355b9f308dfa7 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Sat, 20 Sep 2025 20:03:49 -0600 Subject: [PATCH 2/2] formatting --- crates/turborepo-lib/src/task_hash.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/turborepo-lib/src/task_hash.rs b/crates/turborepo-lib/src/task_hash.rs index 184670fe245cf..11b8399168943 100644 --- a/crates/turborepo-lib/src/task_hash.rs +++ b/crates/turborepo-lib/src/task_hash.rs @@ -6,25 +6,25 @@ use std::{ use rayon::prelude::*; use serde::Serialize; use thiserror::Error; -use tracing::{Span, debug}; +use tracing::{debug, Span}; use turbopath::{AbsoluteSystemPath, AnchoredSystemPath, AnchoredSystemPathBuf}; use turborepo_cache::CacheHitMetadata; use turborepo_env::{BySource, DetailedMap, EnvironmentVariableMap}; -use turborepo_frameworks::{Slug as FrameworkSlug, infer_framework}; +use turborepo_frameworks::{infer_framework, Slug as FrameworkSlug}; use turborepo_repository::package_graph::{PackageInfo, PackageName}; use turborepo_scm::SCM; use turborepo_task_id::TaskId; use turborepo_telemetry::events::{ - EventBuilder, generic::GenericEventBuilder, task::PackageTaskEventBuilder, + generic::GenericEventBuilder, task::PackageTaskEventBuilder, EventBuilder, }; use crate::{ - DaemonClient, DaemonConnector, cli::EnvMode, engine::TaskNode, hash::{FileHashes, LockFilePackages, TaskHashable, TurboHash}, opts::RunOpts, task_graph::TaskDefinition, + DaemonClient, DaemonConnector, }; #[derive(Debug, Error)] @@ -149,9 +149,9 @@ impl PackageInputsHashes { ); }) .ok() // If we timed out, we don't need to - // error, - // just return None so we can move on to - // local + // error, + // just return None so we can move on to + // local }) .and_then(|result| { match result {