From 3026b6054b0f2b73eed01369978daa9428746f96 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Thu, 21 Aug 2025 14:44:22 -0400 Subject: [PATCH 1/3] chore: fix new lints --- crates/turborepo-ci/src/vendor_behavior.rs | 2 +- crates/turborepo-ci/src/vendors.rs | 2 +- crates/turborepo-wax/src/lib.rs | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/turborepo-ci/src/vendor_behavior.rs b/crates/turborepo-ci/src/vendor_behavior.rs index 54de63b717d40..bd03381b9399e 100644 --- a/crates/turborepo-ci/src/vendor_behavior.rs +++ b/crates/turborepo-ci/src/vendor_behavior.rs @@ -5,7 +5,7 @@ use chrono::{DateTime, Utc}; pub type GroupPrefixFn = Arc) -> String + Send + Sync>; type GroupPrefixFnFactory = fn(group_name: String) -> GroupPrefixFn; -#[derive(Clone, Debug, PartialEq)] +#[derive(Clone, Debug)] pub struct VendorBehavior { pub group_prefix: GroupPrefixFnFactory, pub group_suffix: GroupPrefixFnFactory, diff --git a/crates/turborepo-ci/src/vendors.rs b/crates/turborepo-ci/src/vendors.rs index 2876e6bf8997d..a1f4d60db5b24 100644 --- a/crates/turborepo-ci/src/vendors.rs +++ b/crates/turborepo-ci/src/vendors.rs @@ -12,7 +12,7 @@ pub struct VendorEnvs { pub(crate) all: Vec<&'static str>, } -#[derive(Clone, Debug, PartialEq)] +#[derive(Clone, Debug)] #[allow(dead_code)] pub struct Vendor { pub(crate) name: &'static str, diff --git a/crates/turborepo-wax/src/lib.rs b/crates/turborepo-wax/src/lib.rs index 6c910c7982c7f..a7c488c55710a 100644 --- a/crates/turborepo-wax/src/lib.rs +++ b/crates/turborepo-wax/src/lib.rs @@ -12,6 +12,7 @@ #![doc( html_logo_url = "https://raw.githubusercontent.com/olson-sean-k/wax/master/doc/wax.svg?sanitize=true" )] +#![allow(dead_code)] #![allow(clippy::all)] #![deny( clippy::cast_lossless, From 66d6b4ff80165d9b628201666b2b5913f83df4f1 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Thu, 21 Aug 2025 14:46:08 -0400 Subject: [PATCH 2/3] chore: collapse if statement --- crates/turborepo-filewatch/src/fsevent.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/crates/turborepo-filewatch/src/fsevent.rs b/crates/turborepo-filewatch/src/fsevent.rs index 5376ca38b8ae3..e211b98aed795 100644 --- a/crates/turborepo-filewatch/src/fsevent.rs +++ b/crates/turborepo-filewatch/src/fsevent.rs @@ -562,11 +562,11 @@ unsafe fn callback_impl( if *r || &path == p { handle_event = true; break; - } else if let Some(parent_path) = path.parent() { - if parent_path == p { - handle_event = true; - break; - } + } else if let Some(parent_path) = path.parent() + && parent_path == p + { + handle_event = true; + break; } } } From dad5b0a7f469e97293efc8f0d3c0a773374fee75 Mon Sep 17 00:00:00 2001 From: Chris Olszewski Date: Mon, 25 Aug 2025 09:07:28 -0400 Subject: [PATCH 3/3] check name, not impl --- crates/turborepo-ci/src/lib.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/turborepo-ci/src/lib.rs b/crates/turborepo-ci/src/lib.rs index 53ce07836e496..511b40df9d8bb 100644 --- a/crates/turborepo-ci/src/lib.rs +++ b/crates/turborepo-ci/src/lib.rs @@ -190,7 +190,10 @@ mod tests { unsafe { env::set_var(key, val) }; } - assert_eq!(Vendor::infer_inner(), want.as_ref()); + assert_eq!( + Vendor::infer_inner().map(|v| v.name), + want.as_ref().map(|v| v.name) + ); if Vendor::get_name() == Some("GitHub Actions") { if let Some(live_ci) = live_ci {