这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(docs): update redirects rule to resolve access issue on getting-started index page #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

ohprettyhak
Copy link
Contributor

Description

This PR fixes a redirection issue where clicking the “Next: Getting Started” button at the bottom of the Introduction page in the Turborepo docs incorrectly navigates back to the Introduction page.

The root cause is a redirect rule defined in next.config.ts that overrides the expected navigation.
To resolve this, the conflicting redirects rule has been removed to allow proper access to the Getting Started index page.

Testing Instructions

  1. Clone this PR locally and run the project.
  2. Navigate to the Introduction page in the documentation.
  3. Click on the “Next: Getting Started” button at the bottom.
  4. Verify that it correctly navigates to the Getting Started index page instead of redirecting back to Introduction.

@ohprettyhak ohprettyhak requested review from anthonyshew and a team as code owners April 6, 2025 05:46
@ohprettyhak ohprettyhak requested a review from tknickman April 6, 2025 05:46
@turbo-orchestrator turbo-orchestrator bot added area: site needs: triage New issues get this label. Remove it after triage labels Apr 6, 2025
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 8:31pm

Copy link

vercel bot commented Apr 6, 2025

@ohprettyhak is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@@ -40,11 +40,6 @@ const config = {
},
redirects() {
return [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return [
return [
{
source: "/docs/getting-started",
destination: "/repo/docs/getting-started/installation",
permanent: true,
},

If the Getting Started index page is no longer needed, it would be more appropriate to update the redirect rule to point directly to /getting-started/installation instead.

@ohprettyhak ohprettyhak changed the title fix(docs): update redirects rule to resolve access issue on `getting-started index page fix(docs): update redirects rule to resolve access issue on getting-started index page Apr 6, 2025
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good find! Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) April 7, 2025 20:27
@anthonyshew
Copy link
Contributor

CI is stuck on unrelated checks. Merging past these.

@anthonyshew anthonyshew merged commit 75a4185 into vercel:main Apr 7, 2025
10 of 13 checks passed
@ohprettyhak ohprettyhak deleted the fix/docs/getting-started branch April 8, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: site needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants