feat: allow Watch Mode with --root-turbo-json
#10687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
--root-turbo-json
anthonyshew
commented
Jul 18, 2025
chris-olszewski
requested changes
Jul 18, 2025
There was a problem hiding this comment.
This currently does not catch any changes if the turbo.json doesn't reside inside of the repository.
We need to either:
- warn users that
turbo.jsonoutside of the repository will not have changes picked up - start watching outside the repo in the directory that the root
turbo.json
If we want to get this out, I think the former is the better option. The second one might be a little tricky to make sure we don't watch too many files.
|
Thanks for the review, @chris-olszewski. Should have all those noob mistakes buttoned up and chose to go with:
|
chris-olszewski
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unblock Watch Mode from being used with
--root-turbo-json.Testing Instructions
I tested this manually by using
turbo watch lint --root-turbo-json=./some-dir/turbo.jsonin acreate-turboand changing that file. The tasks would be picked up and re-ran the same as if I omitted the--root-turbo-jsonand used a standard path.I also tried it with a JSONC and it worked.