chore: add unit test coverage reporter #10641
Merged
+440
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jul 7, 2025
anthonyshew
commented
Jul 8, 2025
chris-olszewski
approved these changes
Jul 8, 2025
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
|
This warning means that the report is over-reporting.Poking around I'm seeing issues like llvm/llvm-project#72786, meaning there might not be much we can do here beyond trying to change versions of toolchains and tools. ITG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been using LLMs to write code a lot lately and realized that it makes the cost of authoring a unit test significantly lower. It's been changing my opinion on how many unit tests/how much coverage we should have. If the cost of a test is dramatically cheaper, would we want to increase our coverage? Is it too extreme to say now we want 100%?
To that end, I just wanted to see what our coverage is today. This PR adds a quick and dirty reporter, just to see how things look. I don't think its useful to run it in CI or anything of that nature yet, until we form a clearer opinion about what I mentioned in the previous paragraph.
This implementation is based on https://doc.rust-lang.org/rustc/instrument-coverage.html.
Testing Instructions
Run the commands that have been added.