feat(turbo.json): allow for trailing commas #10537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
chris-olszewski
commented
Jun 2, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://turborepo.com/schema.json",, | |||
There was a problem hiding this comment.
For whatever reason, double , with trailing commas really creates a wild output that isn't useful when snapshot. The error could be better, but ITG as the first error still highlights the double ,,
turbo_json_parse_error
× Failed to parse turbo.json.
├─▶ × expected `}` but instead found `,`
│ ╭─[turbo.json:2:50]
│ 1 │ {
│ 2 │ "$schema": "https://turborepo.com/schema.json",,
│ · ─
│ 3 │ "ui": "tui",
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:3:3]
│ 2 │ "$schema": "https://turborepo.com/schema.json",,
│ 3 │ "ui": "tui",
│ · ────
│ 4 │ "tasks": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:3:7]
│ 2 │ "$schema": "https://turborepo.com/schema.json",,
│ 3 │ "ui": "tui",
│ · ─
│ 4 │ "tasks": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:3:9]
│ 2 │ "$schema": "https://turborepo.com/schema.json",,
│ 3 │ "ui": "tui",
│ · ─────
│ 4 │ "tasks": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:3:14]
│ 2 │ "$schema": "https://turborepo.com/schema.json",,
│ 3 │ "ui": "tui",
│ · ─
│ 4 │ "tasks": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:4:3]
│ 3 │ "ui": "tui",
│ 4 │ "tasks": {
│ · ───────
│ 5 │ "build": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:4:10]
│ 3 │ "ui": "tui",
│ 4 │ "tasks": {
│ · ─
│ 5 │ "build": {
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:4:12]
│ 3 │ "ui": "tui",
│ 4 │ ╭─▶ "tasks": {
│ 5 │ │ "build": {
│ 6 │ │ "dependsOn": ["^build"],
│ 7 │ │ "inputs": ["$TURBO_DEFAULT$", ".env*"],
│ 8 │ │ "outputs": [".next/**", "!.next/cache/**"],
│ 9 │ │ },
│ 10 │ │ "lint": {
│ 11 │ │ "dependsOn": ["^lint"]
│ 12 │ │ },
│ 13 │ │ "check-types": {
│ 14 │ │ "dependsOn": ["^check-types"]
│ 15 │ │ },
│ 16 │ │ "dev": {
│ 17 │ │ "cache": false,
│ 18 │ │ "persistent": true
│ 19 │ │ }
│ 20 │ ╰─▶ }
│ 21 │ }
│ ╰────
├─▶ × End of file expected
│ ╭─[turbo.json:21:1]
│ 20 │ }
│ 21 │ }
│ · ─
│ ╰────
╰─▶ × turbo.json has an incorrect type, expected an object, but received an array.
anthonyshew
approved these changes
Jun 2, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10499
Testing Instructions