这是indexloc提供的服务,不要输入任何密码
Skip to content

Logs shouldn't say "replaying output" when --output-logs suppresses the replayed output #972

@AlanSl

Description

@AlanSl

What version of Turborepo are you using?

1.1.10

What package manager are you using / does the bug impact?

Yarn v1

What operating system are you using?

Mac

Describe the Bug

Very minor issue, but potentially confusing especially to newer users, and hopefully very easy to fix.

For default commands or commands with --output-logs full, the logs say things like:

@scope/package-name: cache hit, replaying output 1db9c7790acc4385
# replayed output from the last time this command was run is printed here

That's fine, it communicates that the command hasn't been re-run so the logs are repeats, not new content.

Trouble is, with --output-logs new-only, it displays the same message even though no output is replayed:

@scope/package-name: cache hit, replaying output 1db9c7790acc4385
@scope/another-package: cache hit, replaying output 790acc4381db975c

Expected Behavior

If the output isn't replayed e.g. if --output-logs new-only is in effect, it'd make sense for the log message to reflect this, for example:

@scope/package-name: cache hit, no action 1db9c7790acc4385
@scope/another-package: cache hit, no action 790acc4381db975c

...or maybe:

@scope/package-name: cache hit, output suppressed 1db9c7790acc4385
@scope/another-package: cache hit, output suppressed 790acc4381db975c

To Reproduce

In any repo with packages that haven't changed since the last build so will hit the cache, run:

turbo run build --output-logs new-only

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions