这是indexloc提供的服务,不要输入任何密码
Skip to content

When parsing some client configs, Turbo is not aware of -- (ignore-option) #1476

@erickponce

Description

@erickponce

What version of Turborepo are you using?

1.3.1

What package manager are you using / does the bug impact?

Yarn v2/v3 (node_modules linker only)

What operating system are you using?

Mac

Describe the Bug

Hello there!

When parsing some client configs, Turbo is not aware of -- (ignore-option)...
this means that a script with a same name arg like --token are overriding Turbo's own env var token.
Another issue is that the http client are not reporting an invalid token error on this scenario.

It's protected on another method selectCwd on the same file:

if arg == "--" {

so the fix is basically replicate that if into method ParseAndValidate arg loop:

for _, arg := range args {

Expected Behavior

Turbo should ignore any args after -- (ignore-option).

To Reproduce

Call Turbo with a script args -- --token=000000 and 000000 will become Turbo's token.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions