-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Description
What version of Turborepo are you using?
1.3.1
What package manager are you using / does the bug impact?
Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
Hello there!
When parsing some client configs, Turbo is not aware of --
(ignore-option)...
this means that a script with a same name arg like --token
are overriding Turbo's own env var token.
Another issue is that the http client are not reporting an invalid token error on this scenario.
It's protected on another method selectCwd
on the same file:
turborepo/cli/internal/config/config.go
Line 245 in d83130a
if arg == "--" { |
so the fix is basically replicate that if into method ParseAndValidate
arg loop:
turborepo/cli/internal/config/config.go
Line 140 in d83130a
for _, arg := range args { |
Expected Behavior
Turbo should ignore any args after --
(ignore-option).
To Reproduce
Call Turbo with a script args -- --token=000000
and 000000 will become Turbo's token.