You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Showcase best practices of using Playwright with Turborepo, including a dedicated @repo/playwright-web package. This pattern is not demonstrated in the codebase yet!
Enrich the ecosystem.
Non-goals
Test too many integrations beyond the absolute minimum necessary to showcase a Playwright example. We shouldn't add unnecessary tools like Tailwind CSS, multiple frameworks, etc. just "for fun".
Use a format that is inconsistent with the Playwright guide. Any inconsistencies should mean that the example OR the guide should be fixed and aligned.
Use practices that are not best practices for Playwright within Turborepo. Specifically, it's a non-goal to embed Playwright directly within an app, like in the with-svelte example.
Background
The Playwright guide is very interesting and insightful, but I always prefer being able to "grab onto" a live example. As a developer and consumer of Turborepo, this gives me confidence and a "seal of approval" that I'm going down the right path of integration, matching tested and proven best practices.
Proposal
Add a with-playwright example into the examples/ directory, with a simple Next.js web app and a matching @repo/playwright package.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Goals
@repo/playwright-webpackage. This pattern is not demonstrated in the codebase yet!Non-goals
with-svelteexample.Background
The Playwright guide is very interesting and insightful, but I always prefer being able to "grab onto" a live example. As a developer and consumer of Turborepo, this gives me confidence and a "seal of approval" that I'm going down the right path of integration, matching tested and proven best practices.
Proposal
with-playwrightexample into theexamples/directory, with a simple Next.jswebapp and a matching@repo/playwrightpackage.Yes, I'm interested in creating this PR!
My only question would be if/how much to use Vitest here - since there is configuration to be made if both are used.
Beta Was this translation helpful? Give feedback.
All reactions