ESLint Report

]", { ...ESPREE_CONFIG, ecmaFeatures: { jsx: true } }), + vk.KEYS, + ["* ~ *"], + ast => [ + ["* ~ *", ast.body[0].declarations[0].init.elements[1]] // entering second JSXElement + ] + ); + + assertEmissions( + { + + // Parse `class A implements B {}` with typescript-eslint. + type: "Program", + errors: [], + comments: [], + sourceType: "module", + body: [ + { + type: "ClassDeclaration", + id: { + type: "Identifier", + name: "A" + }, + superClass: null, + implements: [ + { + type: "ClassImplements", + id: { + type: "Identifier", + name: "B" + }, + typeParameters: null + } + ], + body: { + type: "ClassBody", + body: [] + } + } + ] + }, + vk.unionWith({ + + // see https://github.com/typescript-eslint/typescript-eslint/blob/e4d737b47574ff2c53cabab22853035dfe48c1ed/packages/visitor-keys/src/visitor-keys.ts#L27 + ClassDeclaration: [ + "decorators", + "id", + "typeParameters", + "superClass", + "superTypeParameters", + "implements", + "body" + ] + }), + [":first-child"], + ast => [ + [":first-child", ast.body[0]], // entering first ClassDeclaration + [":first-child", ast.body[0].implements[0]] // entering first ClassImplements + ] + ); + }); + describe("parsing an invalid selector", () => { it("throws a useful error", () => { const emitter = createEmitter(); emitter.on("Foo >", () => {}); assert.throws( - () => new NodeEventGenerator(emitter), + () => new NodeEventGenerator(emitter, STANDARD_ESQUERY_OPTION), /Syntax error in selector "Foo >" at position 5: Expected " ", "!", .*/u ); }); diff --git a/tests/lib/linter/report-translator.js b/tests/lib/linter/report-translator.js index 4d137b578ba7..c6dd242e3300 100644 --- a/tests/lib/linter/report-translator.js +++ b/tests/lib/linter/report-translator.js @@ -626,7 +626,7 @@ describe("createReportTranslator", () => { ); }); - // This isn't offically supported, but autofix works the same way + // This isn't officially supported, but autofix works the same way it("should remove the whole suggestion if 'fix' function didn't return anything.", () => { const reportDescriptor = { node, @@ -1028,5 +1028,38 @@ describe("createReportTranslator", () => { "Node must be provided when reporting error if location is not provided" ); }); + + it("should throw an error if fix range is invalid", () => { + assert.throws( + () => translateReport({ node, messageId: "testMessage", fix: () => ({ text: "foo" }) }), + "Fix has invalid range" + ); + + for (const badRange of [[0], [0, null], [null, 0], [void 0, 1], [0, void 0], [void 0, void 0], []]) { + assert.throws( + // eslint-disable-next-line no-loop-func + () => translateReport( + { node, messageId: "testMessage", fix: () => ({ range: badRange, text: "foo" }) } + ), + "Fix has invalid range" + ); + + assert.throws( + // eslint-disable-next-line no-loop-func + () => translateReport( + { + node, + messageId: "testMessage", + fix: () => [ + { range: [0, 0], text: "foo" }, + { range: badRange, text: "bar" }, + { range: [1, 1], text: "baz" } + ] + } + ), + "Fix has invalid range" + ); + } + }); }); }); diff --git a/tests/lib/rule-tester/rule-tester.js b/tests/lib/rule-tester/rule-tester.js index 3f2393621b6b..70647b186702 100644 --- a/tests/lib/rule-tester/rule-tester.js +++ b/tests/lib/rule-tester/rule-tester.js @@ -11,8 +11,7 @@ const sinon = require("sinon"), EventEmitter = require("events"), { RuleTester } = require("../../../lib/rule-tester"), assert = require("chai").assert, - nodeAssert = require("assert"), - { noop } = require("lodash"); + nodeAssert = require("assert"); const NODE_ASSERT_STRICT_EQUAL_OPERATOR = (() => { try { @@ -23,6 +22,15 @@ const NODE_ASSERT_STRICT_EQUAL_OPERATOR = (() => { throw new Error("unexpected successful assertion"); })(); +/** + * Do nothing. + * @returns {void} + */ +function noop() { + + // do nothing. +} + //------------------------------------------------------------------------------ // Rewire Things //------------------------------------------------------------------------------ @@ -89,6 +97,266 @@ describe("RuleTester", () => { ruleTester = new RuleTester(); }); + describe("only", () => { + describe("`itOnly` accessor", () => { + describe("when `itOnly` is set", () => { + before(() => { + RuleTester.itOnly = sinon.spy(); + }); + after(() => { + RuleTester.itOnly = void 0; + }); + beforeEach(() => { + RuleTester.itOnly.resetHistory(); + ruleTester = new RuleTester(); + }); + + it("is called by exclusive tests", () => { + ruleTester.run("no-var", require("../../fixtures/testers/rule-tester/no-var"), { + valid: [{ + code: "const notVar = 42;", + only: true + }], + invalid: [] + }); + + sinon.assert.calledWith(RuleTester.itOnly, "const notVar = 42;"); + }); + }); + + describe("when `it` is set and has an `only()` method", () => { + before(() => { + RuleTester.it.only = () => {}; + sinon.spy(RuleTester.it, "only"); + }); + after(() => { + RuleTester.it.only = void 0; + }); + beforeEach(() => { + RuleTester.it.only.resetHistory(); + ruleTester = new RuleTester(); + }); + + it("is called by tests with `only` set", () => { + ruleTester.run("no-var", require("../../fixtures/testers/rule-tester/no-var"), { + valid: [{ + code: "const notVar = 42;", + only: true + }], + invalid: [] + }); + + sinon.assert.calledWith(RuleTester.it.only, "const notVar = 42;"); + }); + }); + + describe("when global `it` is a function that has an `only()` method", () => { + let originalGlobalItOnly; + + before(() => { + + /* + * We run tests with `--forbid-only`, so we have to override + * `it.only` to prevent the real one from being called. + */ + originalGlobalItOnly = it.only; + it.only = () => {}; + sinon.spy(it, "only"); + }); + after(() => { + it.only = originalGlobalItOnly; + }); + beforeEach(() => { + it.only.resetHistory(); + ruleTester = new RuleTester(); + }); + + it("is called by tests with `only` set", () => { + ruleTester.run("no-var", require("../../fixtures/testers/rule-tester/no-var"), { + valid: [{ + code: "const notVar = 42;", + only: true + }], + invalid: [] + }); + + sinon.assert.calledWith(it.only, "const notVar = 42;"); + }); + }); + + describe("when `describe` and `it` are overridden without `itOnly`", () => { + let originalGlobalItOnly; + + before(() => { + + /* + * These tests override `describe` and `it` already, so we + * don't need to override them here. We do, however, need to + * remove `only` from the global `it` to prevent it from + * being used instead. + */ + originalGlobalItOnly = it.only; + it.only = void 0; + }); + after(() => { + it.only = originalGlobalItOnly; + }); + beforeEach(() => { + ruleTester = new RuleTester(); + }); + + it("throws an error recommending overriding `itOnly`", () => { + assert.throws(() => { + ruleTester.run("no-var", require("../../fixtures/testers/rule-tester/no-var"), { + valid: [{ + code: "const notVar = 42;", + only: true + }], + invalid: [] + }); + }, "Set `RuleTester.itOnly` to use `only` with a custom test framework."); + }); + }); + + describe("when global `it` is a function that does not have an `only()` method", () => { + let originalGlobalIt; + let originalRuleTesterDescribe; + let originalRuleTesterIt; + + before(() => { + originalGlobalIt = global.it; + + // eslint-disable-next-line no-global-assign + it = () => {}; + + /* + * These tests override `describe` and `it`, so we need to + * un-override them here so they won't interfere. + */ + originalRuleTesterDescribe = RuleTester.describe; + RuleTester.describe = void 0; + originalRuleTesterIt = RuleTester.it; + RuleTester.it = void 0; + }); + after(() => { + + // eslint-disable-next-line no-global-assign + it = originalGlobalIt; + RuleTester.describe = originalRuleTesterDescribe; + RuleTester.it = originalRuleTesterIt; + }); + beforeEach(() => { + ruleTester = new RuleTester(); + }); + + it("throws an error explaining that the current test framework does not support `only`", () => { + assert.throws(() => { + ruleTester.run("no-var", require("../../fixtures/testers/rule-tester/no-var"), { + valid: [{ + code: "const notVar = 42;", + only: true + }], + invalid: [] + }); + }, "The current test framework does not support exclusive tests with `only`."); + }); + }); + }); + + describe("test cases", () => { + const ruleName = "no-var"; + const rule = require("../../fixtures/testers/rule-tester/no-var"); + + let originalRuleTesterIt; + let spyRuleTesterIt; + let originalRuleTesterItOnly; + let spyRuleTesterItOnly; + + before(() => { + originalRuleTesterIt = RuleTester.it; + spyRuleTesterIt = sinon.spy(); + RuleTester.it = spyRuleTesterIt; + originalRuleTesterItOnly = RuleTester.itOnly; + spyRuleTesterItOnly = sinon.spy(); + RuleTester.itOnly = spyRuleTesterItOnly; + }); + after(() => { + RuleTester.it = originalRuleTesterIt; + RuleTester.itOnly = originalRuleTesterItOnly; + }); + beforeEach(() => { + spyRuleTesterIt.resetHistory(); + spyRuleTesterItOnly.resetHistory(); + ruleTester = new RuleTester(); + }); + + it("isn't called for normal tests", () => { + ruleTester.run(ruleName, rule, { + valid: ["const notVar = 42;"], + invalid: [] + }); + sinon.assert.calledWith(spyRuleTesterIt, "const notVar = 42;"); + sinon.assert.notCalled(spyRuleTesterItOnly); + }); + + it("calls it or itOnly for every test case", () => { + + /* + * `RuleTester` doesn't implement test case exclusivity itself. + * Setting `only: true` just causes `RuleTester` to call + * whatever `only()` function is provided by the test framework + * instead of the regular `it()` function. + */ + + ruleTester.run(ruleName, rule, { + valid: [ + "const valid = 42;", + { + code: "const onlyValid = 42;", + only: true + } + ], + invalid: [ + { + code: "var invalid = 42;", + errors: [/^Bad var/u] + }, + { + code: "var onlyInvalid = 42;", + errors: [/^Bad var/u], + only: true + } + ] + }); + + sinon.assert.calledWith(spyRuleTesterIt, "const valid = 42;"); + sinon.assert.calledWith(spyRuleTesterItOnly, "const onlyValid = 42;"); + sinon.assert.calledWith(spyRuleTesterIt, "var invalid = 42;"); + sinon.assert.calledWith(spyRuleTesterItOnly, "var onlyInvalid = 42;"); + }); + }); + + describe("static helper wrapper", () => { + it("adds `only` to string test cases", () => { + const test = RuleTester.only("const valid = 42;"); + + assert.deepStrictEqual(test, { + code: "const valid = 42;", + only: true + }); + }); + + it("adds `only` to object test cases", () => { + const test = RuleTester.only({ code: "const valid = 42;" }); + + assert.deepStrictEqual(test, { + code: "const valid = 42;", + only: true + }); + }); + }); + }); + it("should not throw an error when everything passes", () => { ruleTester.run("no-eval", require("../../fixtures/testers/rule-tester/no-eval"), { valid: [ diff --git a/tests/lib/rules/arrow-body-style.js b/tests/lib/rules/arrow-body-style.js index 7a8de4fe5eff..0ccb440d3921 100644 --- a/tests/lib/rules/arrow-body-style.js +++ b/tests/lib/rules/arrow-body-style.js @@ -810,6 +810,14 @@ ruleTester.run("arrow-body-style", rule, { `, options: ["always"], errors: [{ messageId: "expectedBlock" }] + }, + + // https://github.com/eslint/eslint/issues/14633 + { + code: "const createMarker = (color) => ({ latitude, longitude }, index) => {};", + output: "const createMarker = (color) => {return ({ latitude, longitude }, index) => {}};", + options: ["always"], + errors: [{ messageId: "expectedBlock" }] } ] }); diff --git a/tests/lib/rules/complexity.js b/tests/lib/rules/complexity.js index b49ccfc5077c..cf7605baffab 100644 --- a/tests/lib/rules/complexity.js +++ b/tests/lib/rules/complexity.js @@ -48,7 +48,7 @@ function makeError(name, complexity, max) { }; } -const ruleTester = new RuleTester(); +const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2021 } }); ruleTester.run("complexity", rule, { valid: [ @@ -66,6 +66,18 @@ ruleTester.run("complexity", rule, { { code: "function a(x) {return x === 4 ? 3 : (x === 3 ? 2 : 1);}", options: [3] }, { code: "function a(x) {return x || 4;}", options: [2] }, { code: "function a(x) {x && 4;}", options: [2] }, + { code: "function a(x) {x ?? 4;}", options: [2] }, + { code: "function a(x) {x ||= 4;}", options: [2] }, + { code: "function a(x) {x &&= 4;}", options: [2] }, + { code: "function a(x) {x ??= 4;}", options: [2] }, + { code: "function a(x) {x = 4;}", options: [1] }, + { code: "function a(x) {x |= 4;}", options: [1] }, + { code: "function a(x) {x &= 4;}", options: [1] }, + { code: "function a(x) {x += 4;}", options: [1] }, + { code: "function a(x) {x >>= 4;}", options: [1] }, + { code: "function a(x) {x >>>= 4;}", options: [1] }, + { code: "function a(x) {x == 4;}", options: [1] }, + { code: "function a(x) {x === 4;}", options: [1] }, { code: "function a(x) {switch(x){case 1: 1; break; case 2: 2; break; default: 3;}}", options: [3] }, { code: "function a(x) {switch(x){case 1: 1; break; case 2: 2; break; default: if(x == 'foo') {5;};}}", options: [4] }, { code: "function a(x) {while(true) {'foo';}}", options: [2] }, @@ -95,6 +107,10 @@ ruleTester.run("complexity", rule, { { code: "function a(x) {return x === 4 ? 3 : (x === 3 ? 2 : 1);}", options: [2], errors: 1 }, { code: "function a(x) {return x || 4;}", options: [1], errors: 1 }, { code: "function a(x) {x && 4;}", options: [1], errors: 1 }, + { code: "function a(x) {x ?? 4;}", options: [1], errors: 1 }, + { code: "function a(x) {x ||= 4;}", options: [1], errors: 1 }, + { code: "function a(x) {x &&= 4;}", options: [1], errors: 1 }, + { code: "function a(x) {x ??= 4;}", options: [1], errors: 1 }, { code: "function a(x) {switch(x){case 1: 1; break; case 2: 2; break; default: 3;}}", options: [2], errors: 1 }, { code: "function a(x) {switch(x){case 1: 1; break; case 2: 2; break; default: if(x == 'foo') {5;};}}", options: [3], errors: 1 }, { code: "function a(x) {while(true) {'foo';}}", options: [1], errors: 1 }, diff --git a/tests/lib/rules/indent.js b/tests/lib/rules/indent.js index ad35ad09c70d..02517ffaeeb1 100644 --- a/tests/lib/rules/indent.js +++ b/tests/lib/rules/indent.js @@ -2204,6 +2204,26 @@ ruleTester.run("indent", rule, { `, options: [4, { offsetTernaryExpressions: true }] }, + { + code: unIndent` + condition1 + ? condition2 + ? Promise.resolve(1) + : Promise.resolve(2) + : Promise.resolve(3) + `, + options: [2, { offsetTernaryExpressions: true }] + }, + { + code: unIndent` + condition1 + ? Promise.resolve(1) + : condition2 + ? Promise.resolve(2) + : Promise.resolve(3) + `, + options: [2, { offsetTernaryExpressions: true }] + }, { code: unIndent` condition @@ -4125,7 +4145,7 @@ ruleTester.run("indent", rule, { //---------------------------------------------------------------------- // JSX tests // https://github.com/eslint/eslint/issues/8425 - // Some of the following tests are adapted from the the tests in eslint-plugin-react. + // Some of the following tests are adapted from the tests in eslint-plugin-react. // License: https://github.com/yannickcr/eslint-plugin-react/blob/7ca9841f22d599f447a27ef5b2a97def9229d6c8/LICENSE //---------------------------------------------------------------------- @@ -9825,7 +9845,7 @@ ruleTester.run("indent", rule, { //---------------------------------------------------------------------- // JSX tests - // Some of the following tests are adapted from the the tests in eslint-plugin-react. + // Some of the following tests are adapted from the tests in eslint-plugin-react. // License: https://github.com/yannickcr/eslint-plugin-react/blob/7ca9841f22d599f447a27ef5b2a97def9229d6c8/LICENSE //---------------------------------------------------------------------- diff --git a/tests/lib/rules/no-duplicate-imports.js b/tests/lib/rules/no-duplicate-imports.js index 42d35c857513..e200bbc704df 100644 --- a/tests/lib/rules/no-duplicate-imports.js +++ b/tests/lib/rules/no-duplicate-imports.js @@ -16,7 +16,7 @@ const rule = require("../../../lib/rules/no-duplicate-imports"), // Tests //------------------------------------------------------------------------------ -const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6, sourceType: "module" } }); +const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 12, sourceType: "module" } }); ruleTester.run("no-duplicate-imports", rule, { valid: [ @@ -26,6 +26,9 @@ ruleTester.run("no-duplicate-imports", rule, { "import * as Foobar from \"async\";", "import \"foo\"", "import os from \"os\";\nexport { something } from \"os\";", + "import * as bar from \"os\";\nimport { baz } from \"os\";", + "import foo, * as bar from \"os\";\nimport { baz } from \"os\";", + "import foo, { bar } from \"os\";\nimport * as baz from \"os\";", { code: "import os from \"os\";\nexport { hello } from \"hello\";", options: [{ includeExports: true }] @@ -45,6 +48,26 @@ ruleTester.run("no-duplicate-imports", rule, { { code: "import { merge } from \"lodash-es\";\nexport { merge as lodashMerge }", options: [{ includeExports: true }] + }, + { + code: "export { something } from \"os\";\nexport * as os from \"os\";", + options: [{ includeExports: true }] + }, + { + code: "import { something } from \"os\";\nexport * as os from \"os\";", + options: [{ includeExports: true }] + }, + { + code: "import * as os from \"os\";\nexport { something } from \"os\";", + options: [{ includeExports: true }] + }, + { + code: "import os from \"os\";\nexport * from \"os\";", + options: [{ includeExports: true }] + }, + { + code: "export { something } from \"os\";\nexport * from \"os\";", + options: [{ includeExports: true }] } ], invalid: [ @@ -53,11 +76,22 @@ ruleTester.run("no-duplicate-imports", rule, { errors: [{ messageId: "import", data: { module: "fs" }, type: "ImportDeclaration" }] }, { - code: "import { merge } from \"lodash-es\";import { find } from \"lodash-es\";", + code: "import { merge } from \"lodash-es\";\nimport { find } from \"lodash-es\";", errors: [{ messageId: "import", data: { module: "lodash-es" }, type: "ImportDeclaration" }] }, { - code: "import { merge } from \"lodash-es\";import _ from \"lodash-es\";", + code: "import { merge } from \"lodash-es\";\nimport _ from \"lodash-es\";", + errors: [{ messageId: "import", data: { module: "lodash-es" }, type: "ImportDeclaration" }] + }, + { + code: "import os from \"os\";\nimport { something } from \"os\";\nimport * as foobar from \"os\";", + errors: [ + { messageId: "import", data: { module: "os" }, type: "ImportDeclaration" }, + { messageId: "import", data: { module: "os" }, type: "ImportDeclaration" } + ] + }, + { + code: "import * as modns from \"lodash-es\";\nimport { merge } from \"lodash-es\";\nimport { baz } from \"lodash-es\";", errors: [{ messageId: "import", data: { module: "lodash-es" }, type: "ImportDeclaration" }] }, { @@ -66,7 +100,7 @@ ruleTester.run("no-duplicate-imports", rule, { errors: [{ messageId: "export", data: { module: "os" }, type: "ExportNamedDeclaration" }] }, { - code: "import os from \"os\"; export { os as foobar } from \"os\";\nexport { something } from \"os\";", + code: "import os from \"os\";\nexport { os as foobar } from \"os\";\nexport { something } from \"os\";", options: [{ includeExports: true }], errors: [ { messageId: "exportAs", data: { module: "os" }, type: "ExportNamedDeclaration" }, @@ -80,7 +114,27 @@ ruleTester.run("no-duplicate-imports", rule, { errors: [{ messageId: "exportAs", data: { module: "os" }, type: "ExportNamedDeclaration" }] }, { - code: "import os from \"os\";\nexport * from \"os\";", + code: "import os from \"os\";\nexport * as os from \"os\";", + options: [{ includeExports: true }], + errors: [{ messageId: "exportAs", data: { module: "os" }, type: "ExportAllDeclaration" }] + }, + { + code: "export * as os from \"os\";\nimport os from \"os\";", + options: [{ includeExports: true }], + errors: [{ messageId: "importAs", data: { module: "os" }, type: "ImportDeclaration" }] + }, + { + code: "import * as modns from \"mod\";\nexport * as modns from \"mod\";", + options: [{ includeExports: true }], + errors: [{ messageId: "exportAs", data: { module: "mod" }, type: "ExportAllDeclaration" }] + }, + { + code: "export * from \"os\";\nexport * from \"os\";", + options: [{ includeExports: true }], + errors: [{ messageId: "export", data: { module: "os" }, type: "ExportAllDeclaration" }] + }, + { + code: "import \"os\";\nexport * from \"os\";", options: [{ includeExports: true }], errors: [{ messageId: "exportAs", data: { module: "os" }, type: "ExportAllDeclaration" }] } diff --git a/tests/lib/rules/no-extend-native.js b/tests/lib/rules/no-extend-native.js index ca5b430fafe4..4cb4a64b35c6 100644 --- a/tests/lib/rules/no-extend-native.js +++ b/tests/lib/rules/no-extend-native.js @@ -48,12 +48,6 @@ ruleTester.run("no-extend-native", rule, { { code: "{ let Object = function() {}; Object.prototype.p = 0 }", parserOptions: { ecmaVersion: 6 } - }, - - // TODO(mdjermanovic): This test should become `invalid` in the next major version, when we upgrade the `globals` package. - { - code: "WeakRef.prototype.p = 0", - env: { es2021: true } } ], invalid: [{ @@ -71,6 +65,30 @@ ruleTester.run("no-extend-native", rule, { data: { builtin: "BigInt" }, type: "AssignmentExpression" }] + }, { + code: "WeakRef.prototype.p = 0", + env: { es2021: true }, + errors: [{ + messageId: "unexpected", + data: { builtin: "WeakRef" }, + type: "AssignmentExpression" + }] + }, { + code: "FinalizationRegistry.prototype.p = 0", + env: { es2021: true }, + errors: [{ + messageId: "unexpected", + data: { builtin: "FinalizationRegistry" }, + type: "AssignmentExpression" + }] + }, { + code: "AggregateError.prototype.p = 0", + env: { es2021: true }, + errors: [{ + messageId: "unexpected", + data: { builtin: "AggregateError" }, + type: "AssignmentExpression" + }] }, { code: "Function.prototype['p'] = 0", errors: [{ diff --git a/tests/lib/rules/no-extra-parens.js b/tests/lib/rules/no-extra-parens.js index 3fee9fefd8f4..a14ececc0997 100644 --- a/tests/lib/rules/no-extra-parens.js +++ b/tests/lib/rules/no-extra-parens.js @@ -599,10 +599,44 @@ ruleTester.run("no-extra-parens", rule, { options: ["functions"] }, "(let)[foo]", - "for ((let) in foo);", + + // ForStatement#init expression cannot start with `let[`. It would be parsed as a `let` declaration with array pattern, or a syntax error. + "for ((let[a]);;);", + "for ((let)[a];;);", + "for ((let[a] = 1);;);", + "for ((let[a]) = 1;;);", + "for ((let)[a] = 1;;);", + "for ((let[a, b] = foo);;);", + "for ((let[a].b = 1);;);", + "for ((let[a].b) = 1;;);", + "for ((let[a]).b = 1;;);", + "for ((let)[a].b = 1;;);", + "for ((let[a])();;);", + "for ((let)[a]();;);", + "for ((let[a]) + b;;);", + + // ForInStatement#left expression cannot start with `let[`. It would be parsed as a `let` declaration with array pattern, or a syntax error. "for ((let[foo]) in bar);", "for ((let)[foo] in bar);", "for ((let[foo].bar) in baz);", + "for ((let[foo]).bar in baz);", + "for ((let)[foo].bar in baz);", + + // ForOfStatement#left expression cannot start with `let`. It's explicitly forbidden by the specification. + "for ((let) of foo);", + "for ((let).foo of bar);", + "for ((let.foo) of bar);", + "for ((let[foo]) of bar);", + "for ((let)[foo] of bar);", + "for ((let.foo.bar) of baz);", + "for ((let.foo).bar of baz);", + "for ((let).foo.bar of baz);", + "for ((let[foo].bar) of baz);", + "for ((let[foo]).bar of baz);", + "for ((let)[foo].bar of baz);", + "for ((let)().foo of bar);", + "for ((let()).foo of bar);", + "for ((let().foo) of bar);", // https://github.com/eslint/eslint/issues/11706 (also in invalid[]) "for (let a = (b in c); ;);", @@ -1850,6 +1884,18 @@ ruleTester.run("no-extra-parens", rule, { "Identifier", 1 ), + invalid( + "for (foo of (baz = bar));", + "for (foo of baz = bar);", + "AssignmentExpression", + 1 + ), + invalid( + "function* f() { for (foo of (yield bar)); }", + "function* f() { for (foo of yield bar); }", + "YieldExpression", + 1 + ), invalid( "for (foo of ((bar, baz)));", "for (foo of (bar, baz));", @@ -1880,18 +1926,331 @@ ruleTester.run("no-extra-parens", rule, { "Identifier", 1 ), + + // ForStatement#init expression cannot start with `let[`, but it can start with `let` if it isn't followed by `[` + invalid( + "for ((let);;);", + "for (let;;);", + "Identifier", + 1 + ), + invalid( + "for ((let = 1);;);", + "for (let = 1;;);", + "AssignmentExpression", + 1 + ), + invalid( + "for ((let) = 1;;);", + "for (let = 1;;);", + "Identifier", + 1 + ), + invalid( + "for ((let = []);;);", + "for (let = [];;);", + "AssignmentExpression", + 1 + ), + invalid( + "for ((let) = [];;);", + "for (let = [];;);", + "Identifier", + 1 + ), + invalid( + "for ((let());;);", + "for (let();;);", + "CallExpression", + 1 + ), + invalid( + "for ((let([]));;);", + "for (let([]);;);", + "CallExpression", + 1 + ), + invalid( + "for ((let())[a];;);", + "for (let()[a];;);", + "CallExpression", + 1 + ), + invalid( + "for ((let`[]`);;);", + "for (let`[]`;;);", + "TaggedTemplateExpression", + 1 + ), + invalid( + "for ((let.a);;);", + "for (let.a;;);", + "MemberExpression", + 1 + ), + invalid( + "for ((let).a;;);", + "for (let.a;;);", + "Identifier", + 1 + ), + invalid( + "for ((let).a = 1;;);", + "for (let.a = 1;;);", + "Identifier", + 1 + ), + invalid( + "for ((let).a[b];;);", + "for (let.a[b];;);", + "Identifier", + 1 + ), + invalid( + "for ((let.a)[b];;);", + "for (let.a[b];;);", + "MemberExpression", + 1 + ), + invalid( + "for ((let.a[b]);;);", + "for (let.a[b];;);", + "MemberExpression", + 1 + ), + invalid( + "for ((let);[];);", + "for (let;[];);", + "Identifier", + 1 + ), + invalid( + "for (((let[a]));;);", + "for ((let[a]);;);", + "MemberExpression", + 1 + ), + invalid( + "for (((let))[a];;);", + "for ((let)[a];;);", + "Identifier", + 1 + ), + invalid( + "for (((let[a])).b;;);", + "for ((let[a]).b;;);", + "MemberExpression", + 1 + ), + invalid( + "for (((let))[a].b;;);", + "for ((let)[a].b;;);", + "Identifier", + 1 + ), + invalid( + "for (((let)[a]).b;;);", + "for ((let)[a].b;;);", + "MemberExpression", + 1 + ), + invalid( + "for (((let[a]) = b);;);", + "for ((let[a]) = b;;);", + "AssignmentExpression", + 1 + ), + invalid( + "for (((let)[a]) = b;;);", + "for ((let)[a] = b;;);", + "MemberExpression", + 1 + ), + invalid( + "for (((let)[a] = b);;);", + "for ((let)[a] = b;;);", + "AssignmentExpression", + 1 + ), + invalid( + "for ((Let[a]);;);", + "for (Let[a];;);", + "MemberExpression", + 1 + ), + invalid( + "for ((lett)[a];;);", + "for (lett[a];;);", + "Identifier", + 1 + ), + + // ForInStatement#left expression cannot start with `let[`, but it can start with `let` if it isn't followed by `[` + invalid( + "for ((let) in foo);", + "for (let in foo);", + "Identifier", + 1 + ), + invalid( + "for ((let())[a] in foo);", + "for (let()[a] in foo);", + "CallExpression", + 1 + ), + invalid( + "for ((let.a) in foo);", + "for (let.a in foo);", + "MemberExpression", + 1 + ), + invalid( + "for ((let).a in foo);", + "for (let.a in foo);", + "Identifier", + 1 + ), + invalid( + "for ((let).a.b in foo);", + "for (let.a.b in foo);", + "Identifier", + 1 + ), + invalid( + "for ((let).a[b] in foo);", + "for (let.a[b] in foo);", + "Identifier", + 1 + ), + invalid( + "for ((let.a)[b] in foo);", + "for (let.a[b] in foo);", + "MemberExpression", + 1 + ), + invalid( + "for ((let.a[b]) in foo);", + "for (let.a[b] in foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let[a])) in foo);", + "for ((let[a]) in foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let))[a] in foo);", + "for ((let)[a] in foo);", + "Identifier", + 1 + ), + invalid( + "for (((let[a])).b in foo);", + "for ((let[a]).b in foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let))[a].b in foo);", + "for ((let)[a].b in foo);", + "Identifier", + 1 + ), + invalid( + "for (((let)[a]).b in foo);", + "for ((let)[a].b in foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let[a]).b) in foo);", + "for ((let[a]).b in foo);", + "MemberExpression", + 1 + ), + invalid( + "for ((Let[a]) in foo);", + "for (Let[a] in foo);", + "MemberExpression", + 1 + ), + invalid( + "for ((lett)[a] in foo);", + "for (lett[a] in foo);", + "Identifier", + 1 + ), + + // ForOfStatement#left expression cannot start with `let` invalid( - "for ((let.foo) in bar);", - "for (let.foo in bar);", + "for (((let)) of foo);", + "for ((let) of foo);", + "Identifier", + 1 + ), + invalid( + "for (((let)).a of foo);", + "for ((let).a of foo);", + "Identifier", + 1 + ), + invalid( + "for (((let))[a] of foo);", + "for ((let)[a] of foo);", + "Identifier", + 1 + ), + invalid( + "for (((let).a) of foo);", + "for ((let).a of foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let[a]).b) of foo);", + "for ((let[a]).b of foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let).a).b of foo);", + "for ((let).a.b of foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let).a.b) of foo);", + "for ((let).a.b of foo);", "MemberExpression", 1 ), invalid( - "for ((let).foo.bar in baz);", - "for (let.foo.bar in baz);", + "for (((let.a).b) of foo);", + "for ((let.a).b of foo);", + "MemberExpression", + 1 + ), + invalid( + "for (((let()).a) of foo);", + "for ((let()).a of foo);", + "MemberExpression", + 1 + ), + invalid( + "for ((Let) of foo);", + "for (Let of foo);", + "Identifier", + 1 + ), + invalid( + "for ((lett) of foo);", + "for (lett of foo);", "Identifier", 1 ), + invalid("for (a in (b, c));", "for (a in b, c);", "SequenceExpression", null), invalid( "(let)", diff --git a/tests/lib/rules/no-fallthrough.js b/tests/lib/rules/no-fallthrough.js index e154c31d5f70..0b98d3293e91 100644 --- a/tests/lib/rules/no-fallthrough.js +++ b/tests/lib/rules/no-fallthrough.js @@ -30,6 +30,14 @@ ruleTester.run("no-fallthrough", rule, { "switch(foo) { case 0: a(); /* fall through */ case 1: b(); }", "switch(foo) { case 0: a(); /* fallthrough */ case 1: b(); }", "switch(foo) { case 0: a(); /* FALLS THROUGH */ case 1: b(); }", + "switch(foo) { case 0: { a(); /* falls through */ } case 1: b(); }", + "switch(foo) { case 0: { a()\n /* falls through */ } case 1: b(); }", + "switch(foo) { case 0: { a(); /* fall through */ } case 1: b(); }", + "switch(foo) { case 0: { a(); /* fallthrough */ } case 1: b(); }", + "switch(foo) { case 0: { a(); /* FALLS THROUGH */ } case 1: b(); }", + "switch(foo) { case 0: { a(); } /* falls through */ case 1: b(); }", + "switch(foo) { case 0: { a(); /* falls through */ } /* comment */ case 1: b(); }", + "switch(foo) { case 0: { /* falls through */ } case 1: b(); }", "function foo() { switch(foo) { case 0: a(); return; case 1: b(); }; }", "switch(foo) { case 0: a(); throw 'foo'; case 1: b(); }", "while (a) { switch(foo) { case 0: a(); continue; case 1: b(); } }", @@ -133,6 +141,30 @@ ruleTester.run("no-fallthrough", rule, { code: "switch(foo) { case 0:\n\n default: b() }", errors: errorsDefault }, + { + code: "switch(foo) { case 0: {} default: b() }", + errors: errorsDefault + }, + { + code: "switch(foo) { case 0: a(); { /* falls through */ } default: b() }", + errors: errorsDefault + }, + { + code: "switch(foo) { case 0: { /* falls through */ } a(); default: b() }", + errors: errorsDefault + }, + { + code: "switch(foo) { case 0: if (a) { /* falls through */ } default: b() }", + errors: errorsDefault + }, + { + code: "switch(foo) { case 0: { { /* falls through */ } } default: b() }", + errors: errorsDefault + }, + { + code: "switch(foo) { case 0: { /* comment */ } default: b() }", + errors: errorsDefault + }, { code: "switch(foo) { case 0:\n // comment\n default: b() }", errors: errorsDefault @@ -168,6 +200,20 @@ ruleTester.run("no-fallthrough", rule, { column: 1 } ] + }, + { + code: "switch(foo) { case 0: { a();\n/* no break */\n/* todo: fix readability */ }\ndefault: b() }", + options: [{ + commentPattern: "no break" + }], + errors: [ + { + messageId: "default", + type: "SwitchCase", + line: 4, + column: 1 + } + ] } ] }); diff --git a/tests/lib/rules/no-implicit-coercion.js b/tests/lib/rules/no-implicit-coercion.js index fa2b68b49759..f7ca9dcff3fa 100644 --- a/tests/lib/rules/no-implicit-coercion.js +++ b/tests/lib/rules/no-implicit-coercion.js @@ -88,7 +88,23 @@ ruleTester.run("no-implicit-coercion", rule, { { code: "`${foo}` + ''", parserOptions: { ecmaVersion: 6 } }, "foo += 'bar'", { code: "foo += `${bar}`", parserOptions: { ecmaVersion: 6 } }, - "+42" + { code: "`a${foo}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${foo}b`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${foo}${bar}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "tag`${foo}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${foo}`", parserOptions: { ecmaVersion: 6 } }, + { code: "`${foo}`", options: [{ }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${foo}`", options: [{ disallowTemplateShorthand: false }], parserOptions: { ecmaVersion: 6 } }, + "+42", + + // https://github.com/eslint/eslint/issues/14623 + "'' + String(foo)", + "String(foo) + ''", + { code: "`` + String(foo)", parserOptions: { ecmaVersion: 6 } }, + { code: "String(foo) + ``", parserOptions: { ecmaVersion: 6 } }, + { code: "`${'foo'}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${`foo`}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "`${String(foo)}`", options: [{ disallowTemplateShorthand: true }], parserOptions: { ecmaVersion: 6 } } ], invalid: [ { @@ -248,6 +264,39 @@ ruleTester.run("no-implicit-coercion", rule, { type: "BinaryExpression" }] }, + { + code: "`${foo}`", + output: "String(foo)", + options: [{ disallowTemplateShorthand: true }], + parserOptions: { ecmaVersion: 6 }, + errors: [{ + messageId: "useRecommendation", + data: { recommendation: "String(foo)" }, + type: "TemplateLiteral" + }] + }, + { + code: "`\\\n${foo}`", + output: "String(foo)", + options: [{ disallowTemplateShorthand: true }], + parserOptions: { ecmaVersion: 6 }, + errors: [{ + messageId: "useRecommendation", + data: { recommendation: "String(foo)" }, + type: "TemplateLiteral" + }] + }, + { + code: "`${foo}\\\n`", + output: "String(foo)", + options: [{ disallowTemplateShorthand: true }], + parserOptions: { ecmaVersion: 6 }, + errors: [{ + messageId: "useRecommendation", + data: { recommendation: "String(foo)" }, + type: "TemplateLiteral" + }] + }, { code: "foo += \"\"", output: "foo = String(foo)", diff --git a/tests/lib/rules/no-invalid-regexp.js b/tests/lib/rules/no-invalid-regexp.js index add1af81fa8a..6484db816db5 100644 --- a/tests/lib/rules/no-invalid-regexp.js +++ b/tests/lib/rules/no-invalid-regexp.js @@ -24,30 +24,82 @@ ruleTester.run("no-invalid-regexp", rule, { "new RegExp('.', 'im')", "global.RegExp('\\\\')", "new RegExp('.', y)", - { code: "new RegExp('.', 'y')", options: [{ allowConstructorFlags: ["y"] }] }, - { code: "new RegExp('.', 'u')", options: [{ allowConstructorFlags: ["U"] }] }, - { code: "new RegExp('.', 'yu')", options: [{ allowConstructorFlags: ["y", "u"] }] }, - { code: "new RegExp('/', 'yu')", options: [{ allowConstructorFlags: ["y", "u"] }] }, - { code: "new RegExp('\\/', 'yu')", options: [{ allowConstructorFlags: ["y", "u"] }] }, - { code: "new RegExp('.', 'y')", parserOptions: { ecmaVersion: 6 } }, - { code: "new RegExp('.', 'u')", parserOptions: { ecmaVersion: 6 } }, - { code: "new RegExp('.', 'yu')", parserOptions: { ecmaVersion: 6 } }, - { code: "new RegExp('/', 'yu')", parserOptions: { ecmaVersion: 6 } }, - { code: "new RegExp('\\/', 'yu')", parserOptions: { ecmaVersion: 6 } }, - { code: "new RegExp('\\\\u{65}', 'u')", parserOptions: { ecmaVersion: 2015 } }, - { code: "new RegExp('[\\\\u{0}-\\\\u{1F}]', 'u')", parserOptions: { ecmaVersion: 2015 } }, - { code: "new RegExp('.', 's')", parserOptions: { ecmaVersion: 2018 } }, - { code: "new RegExp('(?<=a)b')", parserOptions: { ecmaVersion: 2018 } }, - { code: "new RegExp('(?b)\\k')", parserOptions: { ecmaVersion: 2018 } }, - { code: "new RegExp('(?b)\\k ', 'u')", parserOptions: { ecmaVersion: 2018 } }, - { code: "new RegExp('\\\\p{Letter}', 'u')", parserOptions: { ecmaVersion: 2018 } }, + "new RegExp('.', 'y')", + "new RegExp('.', 'u')", + "new RegExp('.', 'yu')", + "new RegExp('/', 'yu')", + "new RegExp('\\/', 'yu')", + "new RegExp('\\\\u{65}', 'u')", + "new RegExp('\\\\u{65}*', 'u')", + "new RegExp('[\\\\u{0}-\\\\u{1F}]', 'u')", + "new RegExp('.', 's')", + "new RegExp('(?<=a)b')", + "new RegExp('(?b)\\k ')", + "new RegExp('(?b)\\k ', 'u')", + "new RegExp('\\\\p{Letter}', 'u')", + + // unknown flags + "RegExp('{', flags)", // valid without the "u" flag + "new RegExp('{', flags)", // valid without the "u" flag + "RegExp('\\\\u{0}*', flags)", // valid with the "u" flag + "new RegExp('\\\\u{0}*', flags)", // valid with the "u" flag + { + code: "RegExp('{', flags)", // valid without the "u" flag + options: [{ allowConstructorFlags: ["u"] }] + }, + { + code: "RegExp('\\\\u{0}*', flags)", // valid with the "u" flag + options: [{ allowConstructorFlags: ["a"] }] + }, // ES2020 "new RegExp('(?<\\\\ud835\\\\udc9c>.)', 'g')", "new RegExp('(?<\\\\u{1d49c}>.)', 'g')", "new RegExp('(?<𝒜>.)', 'g');", - "new RegExp('\\\\p{Script=Nandinagari}', 'u');" + "new RegExp('\\\\p{Script=Nandinagari}', 'u');", + + // allowConstructorFlags + { + code: "new RegExp('.', 'g')", + options: [{ allowConstructorFlags: [] }] + }, + { + code: "new RegExp('.', 'g')", + options: [{ allowConstructorFlags: ["a"] }] + }, + { + code: "new RegExp('.', 'a')", + options: [{ allowConstructorFlags: ["a"] }] + }, + { + code: "new RegExp('.', 'ag')", + options: [{ allowConstructorFlags: ["a"] }] + }, + { + code: "new RegExp('.', 'ga')", + options: [{ allowConstructorFlags: ["a"] }] + }, + { + code: "new RegExp('.', 'a')", + options: [{ allowConstructorFlags: ["a", "z"] }] + }, + { + code: "new RegExp('.', 'z')", + options: [{ allowConstructorFlags: ["a", "z"] }] + }, + { + code: "new RegExp('.', 'az')", + options: [{ allowConstructorFlags: ["a", "z"] }] + }, + { + code: "new RegExp('.', 'za')", + options: [{ allowConstructorFlags: ["a", "z"] }] + }, + { + code: "new RegExp('.', 'agz')", + options: [{ allowConstructorFlags: ["a", "z"] }] + } ], invalid: [ { @@ -66,6 +118,42 @@ ruleTester.run("no-invalid-regexp", rule, { type: "CallExpression" }] }, + { + code: "RegExp('.', 'a');", + options: [{}], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid flags supplied to RegExp constructor 'a'" }, + type: "CallExpression" + }] + }, + { + code: "new RegExp('.', 'a');", + options: [{ allowConstructorFlags: [] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid flags supplied to RegExp constructor 'a'" }, + type: "NewExpression" + }] + }, + { + code: "new RegExp('.', 'z');", + options: [{ allowConstructorFlags: ["a"] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid flags supplied to RegExp constructor 'z'" }, + type: "NewExpression" + }] + }, + { + code: "new RegExp('.', 'az');", + options: [{ allowConstructorFlags: ["z"] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid flags supplied to RegExp constructor 'a'" }, + type: "NewExpression" + }] + }, { code: "new RegExp(')');", errors: [{ @@ -74,6 +162,65 @@ ruleTester.run("no-invalid-regexp", rule, { type: "NewExpression" }] }, + { + code: String.raw`new RegExp('\\a', 'u');`, + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\a/u: Invalid escape" }, + type: "NewExpression" + }] + }, + { + code: String.raw`new RegExp('\\a', 'u');`, + options: [{ allowConstructorFlags: ["u"] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\a/u: Invalid escape" }, + type: "NewExpression" + }] + }, + { + code: String.raw`RegExp('\\u{0}*');`, + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\u{0}*/: Nothing to repeat" }, + type: "CallExpression" + }] + }, + { + code: String.raw`new RegExp('\\u{0}*');`, + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\u{0}*/: Nothing to repeat" }, + type: "NewExpression" + }] + }, + { + code: String.raw`new RegExp('\\u{0}*', '');`, + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\u{0}*/: Nothing to repeat" }, + type: "NewExpression" + }] + }, + { + code: String.raw`new RegExp('\\u{0}*', 'a');`, + options: [{ allowConstructorFlags: ["a"] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\u{0}*/: Nothing to repeat" }, + type: "NewExpression" + }] + }, + { + code: String.raw`RegExp('\\u{0}*');`, + options: [{ allowConstructorFlags: ["a"] }], + errors: [{ + messageId: "regexMessage", + data: { message: "Invalid regular expression: /\\u{0}*/: Nothing to repeat" }, + type: "CallExpression" + }] + }, // https://github.com/eslint/eslint/issues/10861 { diff --git a/tests/lib/rules/no-invalid-this.js b/tests/lib/rules/no-invalid-this.js index 6e1b757a7123..3b19d63696f3 100644 --- a/tests/lib/rules/no-invalid-this.js +++ b/tests/lib/rules/no-invalid-this.js @@ -9,7 +9,8 @@ // Requirements //------------------------------------------------------------------------------ -const lodash = require("lodash"); +const merge = require("lodash.merge"); + const rule = require("../../../lib/rules/no-invalid-this"); const { RuleTester } = require("../../../lib/rule-tester"); @@ -69,7 +70,7 @@ function extractPatterns(patterns, type) { // Clone and apply the pattern environment. const patternsList = patterns.map(pattern => pattern[type].map(applyCondition => { - const thisPattern = lodash.cloneDeep(pattern); + const thisPattern = merge({}, pattern); applyCondition(thisPattern); @@ -79,7 +80,10 @@ function extractPatterns(patterns, type) { thisPattern.code += " /* should error */"; } - return lodash.omit(thisPattern, ["valid", "invalid"]); + delete thisPattern.valid; + delete thisPattern.invalid; + + return thisPattern; })); // Flatten. diff --git a/tests/lib/rules/no-mixed-operators.js b/tests/lib/rules/no-mixed-operators.js index 3650cd09fce3..782af07e3103 100644 --- a/tests/lib/rules/no-mixed-operators.js +++ b/tests/lib/rules/no-mixed-operators.js @@ -52,13 +52,29 @@ ruleTester.run("no-mixed-operators", rule, { code: "(a || b) ? c : d", options: [{ groups: [["&&", "||", "?:"]] }] }, + { + code: "a ? (b || c) : d", + options: [{ groups: [["&&", "||", "?:"]] }] + }, + { + code: "a ? b : (c || d)", + options: [{ groups: [["&&", "||", "?:"]] }] + }, { code: "a || (b ? c : d)", options: [{ groups: [["&&", "||", "?:"]] }] }, + { + code: "(a ? b : c) || d", + options: [{ groups: [["&&", "||", "?:"]] }] + }, "a || (b ? c : d)", "(a || b) ? c : d", - "a || b ? c : d" + "a || b ? c : d", + "a ? (b || c) : d", + "a ? b || c : d", + "a ? b : (c || d)", + "a ? b : c || d" ], invalid: [ { diff --git a/tests/lib/rules/no-multi-assign.js b/tests/lib/rules/no-multi-assign.js index dc907465c60b..c534f55b33f9 100644 --- a/tests/lib/rules/no-multi-assign.js +++ b/tests/lib/rules/no-multi-assign.js @@ -51,7 +51,9 @@ ruleTester.run("no-mutli-assign", rule, { { code: "for(let a = 0, b = 0;;){}", parserOptions: { ecmaVersion: 6 } }, { code: "for(const a = 0, b = 0;;){}", parserOptions: { ecmaVersion: 6 } }, { code: "export let a, b;", parserOptions: { ecmaVersion: 6, sourceType: "module" } }, - { code: "export let a,\n b = 0;", parserOptions: { ecmaVersion: 6, sourceType: "module" } } + { code: "export let a,\n b = 0;", parserOptions: { ecmaVersion: 6, sourceType: "module" } }, + { code: "const x = {};const y = {};x.one = y.one = 1;", options: [{ ignoreNonDeclaration: true }], parserOptions: { ecmaVersion: 6 } }, + { code: "let a, b;a = b = 1", options: [{ ignoreNonDeclaration: true }], parserOptions: { ecmaVersion: 6 } } ], invalid: [ @@ -137,6 +139,39 @@ ruleTester.run("no-mutli-assign", rule, { errors: [ errorAt(1, 5, "AssignmentExpression") ] + }, + { + code: "const x = {};\nconst y = x.one = 1;", + options: [{ ignoreNonDeclaration: true }], + parserOptions: { ecmaVersion: 6 }, + errors: [ + errorAt(2, 11, "AssignmentExpression") + ] + + }, + { + code: "let a, b;a = b = 1", + options: [{}], + parserOptions: { ecmaVersion: 6 }, + errors: [ + errorAt(1, 14, "AssignmentExpression") + ] + }, + { + code: "let x, y;x = y = 'baz'", + options: [{ ignoreNonDeclaration: false }], + parserOptions: { ecmaVersion: 6 }, + errors: [ + errorAt(1, 14, "AssignmentExpression") + ] + }, + { + code: "const a = b = 1", + options: [{ ignoreNonDeclaration: true }], + parserOptions: { ecmaVersion: 6 }, + errors: [ + errorAt(1, 11, "AssignmentExpression") + ] } ] }); diff --git a/tests/lib/rules/no-redeclare.js b/tests/lib/rules/no-redeclare.js index f6293b7e1521..f89d6853fa31 100644 --- a/tests/lib/rules/no-redeclare.js +++ b/tests/lib/rules/no-redeclare.js @@ -9,7 +9,6 @@ // Requirements //------------------------------------------------------------------------------ -const path = require("path"); const rule = require("../../../lib/rules/no-redeclare"); const { RuleTester } = require("../../../lib/rule-tester"); @@ -17,7 +16,6 @@ const { RuleTester } = require("../../../lib/rule-tester"); // Tests //------------------------------------------------------------------------------ -const looseParserPath = path.resolve(__dirname, "../../tools/loose-parser.js"); const ruleTester = new RuleTester(); ruleTester.run("no-redeclare", rule, { @@ -205,112 +203,6 @@ ruleTester.run("no-redeclare", rule, { ] }, - // let/const - { - code: "let a; let a;", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "let a; let a;", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015, sourceType: "module" }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "let a; let a;", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015, ecmaFeatures: { globalReturn: true } }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "let a; const a = 0;", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "const a = 0; const a = 0;", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "if (test) { let a; let a; }", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "switch (test) { case 0: let a; let a; }", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "for (let a, a;;);", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "for (let [a, a] in xs);", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "for (let [a, a] of xs);", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "function f() { let a; let a; }", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "function f(a) { let a; }", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - { - code: "function f() { if (test) { let a; let a; } }", - parser: looseParserPath, - parserOptions: { ecmaVersion: 2015 }, - errors: [ - { message: "'a' is already defined.", type: "Identifier" } - ] - }, - // Comments and built-ins. { code: "/*globals Array */", diff --git a/tests/lib/rules/no-restricted-exports.js b/tests/lib/rules/no-restricted-exports.js index 31458f15fc1c..ac0602a25b29 100644 --- a/tests/lib/rules/no-restricted-exports.js +++ b/tests/lib/rules/no-restricted-exports.js @@ -58,7 +58,7 @@ ruleTester.run("no-restricted-exports", rule, { { code: "export { a } from 'foo';", options: [{ restrictedNamedExports: ["x"] }] }, { code: "export { b as a } from 'foo';", options: [{ restrictedNamedExports: ["x"] }] }, - // does not mistakenly disallow non-exported identifers that appear in named export declarations + // does not mistakenly disallow non-exported identifiers that appear in named export declarations { code: "export var b = a;", options: [{ restrictedNamedExports: ["a"] }] }, { code: "export let [b = a] = [];", options: [{ restrictedNamedExports: ["a"] }] }, { code: "export const [b] = [a];", options: [{ restrictedNamedExports: ["a"] }] }, diff --git a/tests/lib/rules/no-restricted-imports.js b/tests/lib/rules/no-restricted-imports.js index 363229712c99..f54d4df03540 100644 --- a/tests/lib/rules/no-restricted-imports.js +++ b/tests/lib/rules/no-restricted-imports.js @@ -37,6 +37,10 @@ ruleTester.run("no-restricted-imports", rule, { code: "import withGitignores from \"foo/bar\";", options: [{ patterns: ["foo/*", "!foo/bar"] }] }, + { + code: "import withPatterns from \"foo/bar\";", + options: [{ patterns: [{ group: ["foo/*", "!foo/bar"], message: "foo is forbidden, use bar instead" }] }] + }, { code: "import AllowedObject from \"foo\";", options: [{ @@ -241,6 +245,36 @@ ruleTester.run("no-restricted-imports", rule, { column: 1, endColumn: 36 }] + }, { + code: "import withPatterns from \"foo/baz\";", + options: [{ patterns: [{ group: ["foo/*", "!foo/bar"], message: "foo is forbidden, use foo/bar instead" }] }], + errors: [{ + message: "'foo/baz' import is restricted from being used by a pattern. foo is forbidden, use foo/bar instead", + type: "ImportDeclaration", + line: 1, + column: 1, + endColumn: 36 + }] + }, { + code: "import withPatterns from \"foo/baz\";", + options: [{ patterns: [{ group: ["foo/bar", "foo/baz"], message: "some foo subimports are restricted" }] }], + errors: [{ + message: "'foo/baz' import is restricted from being used by a pattern. some foo subimports are restricted", + type: "ImportDeclaration", + line: 1, + column: 1, + endColumn: 36 + }] + }, { + code: "import withPatterns from \"foo/bar\";", + options: [{ patterns: [{ group: ["foo/bar"] }] }], + errors: [{ + message: "'foo/bar' import is restricted from being used by a pattern.", + type: "ImportDeclaration", + line: 1, + column: 1, + endColumn: 36 + }] }, { code: "import withGitignores from \"foo/bar\";", options: [{ patterns: ["foo/*", "!foo/baz"] }], diff --git a/tests/lib/rules/no-restricted-syntax.js b/tests/lib/rules/no-restricted-syntax.js index cf8bc4123664..d5fb36aa4725 100644 --- a/tests/lib/rules/no-restricted-syntax.js +++ b/tests/lib/rules/no-restricted-syntax.js @@ -145,18 +145,26 @@ ruleTester.run("no-restricted-syntax", rule, { { messageId: "restrictedSyntax", data: { message: "Using '[optional=true]' is not allowed." }, type: "CallExpression" }, { messageId: "restrictedSyntax", data: { message: "Using '[optional=true]' is not allowed." }, type: "MemberExpression" } ] - } + }, + + // fix https://github.com/estools/esquery/issues/110 + { + code: "a?.b", + options: [":nth-child(1)"], + parserOptions: { ecmaVersion: 2020 }, + errors: [ + { messageId: "restrictedSyntax", data: { message: "Using ':nth-child(1)' is not allowed." }, type: "ExpressionStatement" } + ] + }, - /* - * TODO(mysticatea): fix https://github.com/estools/esquery/issues/110 - * { - * code: "a?.b", - * options: [":nth-child(1)"], - * parserOptions: { ecmaVersion: 2020 }, - * errors: [ - * { messageId: "restrictedSyntax", data: { message: "Using ':nth-child(1)' is not allowed." }, type: "ExpressionStatement" } - * ] - * } - */ + // https://github.com/eslint/eslint/issues/13639#issuecomment-683976062 + { + code: "const foo = [

", + parserOptions: { ecmaFeatures: { jsx: true } } + }, + { + code: "<>", + parserOptions: { ecmaFeatures: { jsx: true } } + }, + { + code: "var partial =

", + parserOptions: { ecmaFeatures: { jsx: true } } + }, + { + code: "var partial =

", + options: [{ enforceForJSX: true }], + parserOptions: { ecmaFeatures: { jsx: true } } + }, + { + code: "var partial = <>", + options: [{ enforceForJSX: true }], + parserOptions: { ecmaFeatures: { jsx: true } } } ], invalid: [ @@ -152,6 +176,20 @@ ruleTester.run("no-unused-expressions", rule, { code: "obj?.foo().bar", parserOptions: { ecmaVersion: 2020 }, errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }] + }, + + // JSX + { + code: "

ESLint Report

Platinum Sponsors

Gold Sponsors

Silver Sponsors

Bronze Sponsors

Gold Sponsors

Silver Sponsors

Bronze Sponsors

ESLint Report