这是indexloc提供的服务,不要输入任何密码
Skip to content

Doc example improvement: 400 should not retry #176

@dmudro

Description

@dmudro

been using wretch for some time, nice little lib indeed.

it might be worth tweaking the retry example or defaults to ignore certain http responses that should almost never retry.

we had a case with Zoom API recently where initial POST resulted in 400 Bad Request which retried a few times and subsequently causing 429 Too Many Requests. things like 400 bad request is almost always client's fault!

maybe adding a simple check in the doc or adding a new option / default?

...
retry({
    ...
    // didn't try this yet:
    until: (response, error) => response && (response.ok || ![408, 413, 500, 502, 503, 504].includes(response.status)),
    // or a new option?
    // retryOnAnyResponse: false,
    retryOnNetworkError: false,
    resolveWithLatestResponse: false
  })
...

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions