fix: support multiple targets #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/tsup/62ESYEfMunH7UB6caT7XKGQY1b7r |
egoist
reviewed
Dec 31, 2021
| } | ||
| if (flags.target) { | ||
| options.target = flags.target.indexOf(',') >= 0 ? flags.target.split(',') : flags.target | ||
| } |
Owner
There was a problem hiding this comment.
I guess you can just do .split without checking index
Owner
There was a problem hiding this comment.
oops I guess this is necessary otherwise this will fail:
Line 11 in 529be68
Contributor
Author
There was a problem hiding this comment.
Oh, I will revert previous change
This reverts commit 1ac2691.
Contributor
|
🎉 This PR is included in version 5.11.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esbuild supports multiple targets, this PR aligned tsup's API to esbuild