feat(minor): support node: import in older node versions
#460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/tsup/Fo7kSh9BkouZpEP9zEhJa5ZXwteV |
node: import in older node versions
|
🎉 This PR is included in version 5.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
RobinTail
added a commit
to RobinTail/express-zod-api
that referenced
this pull request
Jul 23, 2024
Node protocol removal was introduced here for CJS: egoist/tsup#460 The target was set to `es2022` which does not explicitly address Node, therefore it was removed for ESM too. Setting the target to `node18.18.0` enabled the protocol for ESM. The recently added setting allows also to enable it for CJS: egoist/tsup@e7ced34 This will certainly not work in Node below 14.18, but it should not anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bundling a dependency with
import fs from 'node:fs'didn't work with Node v12 because it would convert the import statement to arequire, which requires Node v14.18.0.Changes
node:protocoldisabledoption inexternalPluginin favor of not passing it into esbuild in the first place. Minor performance nitpick since I didn't want to have two different ways of disabling plugins.