这是indexloc提供的服务,不要输入任何密码
Skip to content

fix watch catch error, earlier prev process kill #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

PabloSzx
Copy link
Contributor

While playing with it I realized two thing:

  • If a build error happens on watch-mode, the process is killed because the promise is not being catched
  • It's better to kill the previous onSuccess process as early as possible to give the OS more time to kill the process for the new process to not overlap

@vercel
Copy link

vercel bot commented Mar 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/tsup/AuPSugoeNQNgqmd1KrE4J1zdaT6h
✅ Preview: https://tsup-git-fork-pabloszx-patch-watch-onsuccess-egoist.vercel.app

@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants