diff --git a/docs/advanced-usage/event-logs.md b/docs/advanced-usage/event-logs.md index 645b6f77f0c..1338fd8695c 100644 --- a/docs/advanced-usage/event-logs.md +++ b/docs/advanced-usage/event-logs.md @@ -33,7 +33,6 @@ dokku events Jul 3 16:09:48 dokku.me dokku[127630]: INVOKED: pre-release-buildpack( pythonapp ) Jul 3 16:10:02 dokku.me dokku[128095]: INVOKED: docker-args-run( rubyapp ) Jul 3 16:10:02 dokku.me dokku[128114]: INVOKED: docker-args-run( nhl ) -Jul 3 16:10:03 dokku.me dokku[128136]: INVOKED: post-release-buildpack( pythonapp ) Jul 3 16:10:03 dokku.me dokku[128195]: INVOKED: pre-deploy( pythonapp ) Jul 3 16:10:23 dokku.me dokku[129253]: INVOKED: docker-args-deploy( pythonapp ) Jul 3 16:10:24 dokku.me dokku[129451]: INVOKED: check-deploy( pythonapp 6274ced0d4be11af4490cd18abaf77cdd593f025133f403d984e80d86a39acec web 5000 10.0.16.80 ) @@ -68,8 +67,6 @@ post-build-dockerfile post-delete post-deploy post-domains-update -post-release-buildpack -post-release-dockerfile pre-build-buildpack pre-build-dockerfile pre-delete diff --git a/docs/appendices/0.30.0-migration-guide.md b/docs/appendices/0.30.0-migration-guide.md index 060c1e651d9..9e58f13b918 100644 --- a/docs/appendices/0.30.0-migration-guide.md +++ b/docs/appendices/0.30.0-migration-guide.md @@ -5,3 +5,7 @@ - Support for [SPDY](https://en.wikipedia.org/wiki/SPDY) has been removed. No major browser supports it as of 2021. Custom `nginx.conf.sigil` templates referencing spdy-related variables will continue to build until the 1.0.0 release. - Support for the `DOKKU_SCALE` file - deprecated in 0.25.0 - has been removed in favor of the `formations` key in the `app.json` file. Please see the [process management documentation](/docs/processes/process-management.md#manually-managing-process-scaling) for more information on how to use the `formation` key of the `app.json` file. - The deprecated `--detach` global flag for `dokku run` was removed. Please see the [one-off tasks documentation](/docs/processes/one-off-tasks.md#running-a-detached-container) for more information on running detached containers. +- The following deprecated trigger have been removed in favor of the `post-release-builder` trigger. See the [plugin triggers documentation](https://dokku.com/docs/development/plugin-triggers/#post-release-builder) for more details. + - `post-release-buildpack` + - `post-release-dockerfile` + - `post-release-pack` diff --git a/docs/development/plugin-triggers.md b/docs/development/plugin-triggers.md index 18909330df1..9f3b2f098ca 100644 --- a/docs/development/plugin-triggers.md +++ b/docs/development/plugin-triggers.md @@ -1519,71 +1519,6 @@ BUILDER_TYPE="$1"; APP="$2"; IMAGE=$3 # TODO ``` -### `post-release-buildpack` - -> Warning: Deprecated, please use `post-release-builder` instead -> Warning: Image mutation in this trigger may result in an invalid run state, and is heavily discouraged. - -- Description: Allows you to run commands after environment variables are set for the release step of the deploy. Only applies to apps using buildpacks. -- Invoked by: `internal function dokku_release() (release phase)` -- Arguments: `$APP $IMAGE_TAG` -- Example: - -```shell -#!/usr/bin/env bash - -set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x -source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions" -APP="$1"; IMAGE_TAG="$2"; IMAGE=$(get_app_image_name $APP $IMAGE_TAG) - -# TODO -``` - -### `post-release-pack` - -> Warning: Deprecated, please use `post-release-builder` instead - -> Warning: The pack plugin trigger apis are under development and may change -> between minor releases until the 1.0 release. - -> Warning: Image mutation in this trigger may result in an invalid run state, and is heavily discouraged. - -- Description: Allows you to run commands after environment variables are set for the release step of the deploy. Only applies to apps using pack. -- Invoked by: `internal function dokku_release() (release phase)` -- Arguments: `$APP $IMAGE_TAG` -- Example: - -```shell -#!/usr/bin/env bash - -set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x -source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions" -APP="$1"; IMAGE_TAG="$2"; IMAGE=$(get_app_image_name $APP $IMAGE_TAG) - -# TODO -``` - -### `post-release-dockerfile` - -> Warning: Deprecated, please use `post-release-builder` instead - -> Warning: Image mutation in this trigger may result in an invalid run state, and is heavily discouraged. - -- Description: Allows you to run commands after environment variables are set for the release step of the deploy. Only applies to apps using a dockerfile. -- Invoked by: `internal function dokku_release() (release phase)` -- Arguments: `$APP $IMAGE_TAG` -- Example: - -```shell -#!/usr/bin/env bash - -set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x -source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions" -APP="$1"; IMAGE_TAG="$2"; IMAGE=$(get_app_image_name $APP $IMAGE_TAG) - -# TODO -``` - ### `post-stop` - Description: Can be used to run commands after an app is manually stopped diff --git a/plugins/builder-dockerfile/builder-release b/plugins/builder-dockerfile/builder-release index bfb62353353..26f9d0539fe 100755 --- a/plugins/builder-dockerfile/builder-release +++ b/plugins/builder-dockerfile/builder-release @@ -25,7 +25,6 @@ trigger-builder-dockerfile-builder-release() { return 1 fi - plugn trigger post-release-dockerfile "$APP" "$IMAGE_TAG" plugn trigger post-release-builder "$BUILDER_TYPE" "$APP" "$IMAGE" } diff --git a/plugins/builder-herokuish/builder-release b/plugins/builder-herokuish/builder-release index 7dc7efd4770..ef570ceaac3 100755 --- a/plugins/builder-herokuish/builder-release +++ b/plugins/builder-herokuish/builder-release @@ -30,7 +30,6 @@ trigger-builder-herokuish-builder-release() { return 1 fi - plugn trigger post-release-buildpack "$APP" "$IMAGE_TAG" plugn trigger post-release-builder "$BUILDER_TYPE" "$APP" "$IMAGE" } diff --git a/plugins/builder-pack/builder-release b/plugins/builder-pack/builder-release index 1cce0c6aaa0..0bcb8ace9db 100755 --- a/plugins/builder-pack/builder-release +++ b/plugins/builder-pack/builder-release @@ -16,7 +16,6 @@ trigger-builder-pack-builder-release() { local IMAGE=$(get_app_image_name "$APP" "$IMAGE_TAG") docker-image-labeler --label=com.dokku.image-stage=release --label=com.dokku.app-name=$APP --label=org.label-schema.schema-version=1.0 --label=org.label-schema.vendor=dokku --label=dokku "$IMAGE" - plugn trigger post-release-pack "$APP" "$IMAGE_TAG" plugn trigger post-release-builder "$BUILDER_TYPE" "$APP" "$IMAGE" }