Move deploy script into a plugin #296
Conversation
|
Can't this be handled by a pre/post release hook, which would replace the |
|
Yeah possibly. I suppose I like the idea of moving all the 'default' behaviour into plugins, rather than a single monolithic dokku script. Looks like the "dokku ps" pull request is doing a similar thing anyway, so maybe it's worth just letting that one play out. |
|
This isn't mergeable, though the |
|
We've already started this move to plugins since the dockerfile support. Might as well finish the job. Currently things we getting moved into standard. Not sure we need an actual deploy plugin. Especially if we're going to rework plugins to require a file per command. In that case, its just an organizational choice. |
|
Closing then. If we need further work, it'll be done in a separate pr. Thanks @leemhenson for the initial PR! Sorry for the long wait on a response :( |
Hey. I've moved guts of the deploy command into a new plugin,
01_dokku-deploy. In doing this, it paves the way for other plugins to customise the deploy process a bit more. In my particular case, supporting the Shoreman plugin for greater process control:https://github.com/musicglue/dokku-shoreman/blob/master/run-deploy