这是indexloc提供的服务,不要输入任何密码
Skip to content

Feature request: Show all requested reviewers for a PR #685

@sideshowbarker

Description

@sideshowbarker

Is your feature request related to a problem? Please describe.

The gh-dash built-in PR preview doesn’t show info on exactly who review has been requested from for each PR. Specifically:

  • I can’t tell if the PR is one for which a review was requested from me personally/individually, or instead whether it’s just one for which a review was requested from a GitHub Team I belong to
  • I can’t tell if I’m the only review-requested-from person, or if review has also been requested from other individuals too.

That information matters a lot to me, because when I am triaging PRs, I prioritize those for which review has been requested from only me personally — versus PRs from which review has been requested from a team I belong to, or PRs from which review has been requested from other individuals in addition to me.

mdn/content#41413 is an example of a PR I would, as part of my triage process, give a lower priority to — for two reasons:

  • A review for that PR was not requested from my personally/individually — but instead just from the MDN Web API team I’m a member of.
  • A review for that PR was requested from another individual (wbamberg).

The GitHub web UI shows me Reviewers area — so, using the GitHub web UI allows me to quickly triage that PR. Example:

Image

 
And gh pr view also shows me that information; example:

 
Image

Notice that includes this line:

Image

 
But since gh-dash doesn’t show me that same information, I can’t fully triage that PR in gh-dash — without needing to also either open it in a browser or in gh pr view

Describe the solution you'd like
I’d like for gh-dash to show me the same Reviewers information for a PR that the GitHub web UI shows me for that PR.

Describe alternatives you've considered
In my ~/.config/gh-dash/config.yml, I have the following:

keybindings:
  prs:
    - key: v
      command: clear; gh pr view --comments https:​//github.com/{{.RepoName}}/pull/{{.PrNumber}}; \
          printf "\nPress any key to go back..."; read -n 1 -r

So, I have a decent workaround that lets me use a single keystroke from within gh-dash to get to the info I need. But it’d be even better if I could just get that from the built-in preview in gh-dash itself — without needing to launch something else.

Additional context
No other context. But I’ll note that I plan to write up a patch/PR for this myself — if nobody else beats me to it first.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions