这是indexloc提供的服务,不要输入任何密码
Skip to content

Improve printing #30

@effad

Description

@effad

There's several things we should try to improve printing:

  • com.dlsc.pdfviewfx.PDFBoxDocument.getPageable() creates a PDFPageable which contains a PDDocument that does not get closed after printing. This could be rectified by using the javax.printing API instead of java.awt.print and implementing a print job listener.
  • The awt print dialog looks out of place in a JavaFX application. There is javafx.print API. We should explore using this API (if necessary, maybe javax.printing will already display a nice-enough print dialog)
  • The actual printing is located within the demo app at the moment. On the one hand this makes for a very nice / lean API (only one method -- getPageable). On the other hand it requires clients to change, if changes need to happen (like changing from java.awt.print to another API); Maybe putting the whole print procedure within PDFView would be a good option?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions