fix #7706 add condacmd dir to cmd.exe path on first activation #7735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io> add test_add_prefix_to_path_cmdexe Signed-off-by: Kale Franz <kfranz@continuum.io> add test_add_prefix_to_path_cmdexe Signed-off-by: Kale Franz <kfranz@continuum.io>
mbargull
reviewed
Sep 5, 2018
| raise NotImplementedError() | ||
|
|
||
| def _add_prefix_to_path(self, prefix, starting_path_dirs=None): | ||
| # If this is the first time we're activating an environment, we need to ensure that |
Member
There was a problem hiding this comment.
Is it really only the first time?
If you'd do
conda activate base
conda activate some-other-env
conda activate base
conda activate some-other-env
wouldn't conda.exe precede condacmd/conda.bat on PATH after the second conda activate base so that the last conda activate some-other-env fails?
I'm not really sure on this though and can't check that right now. Maybe create a test case for that?
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7706