13437 Type Hints & docstrings for conda.core.index #13816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @Nathann03. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#916), and ping the bot to refresh the PR. |
Member
|
@conda-bot check |
CodSpeed Performance ReportMerging #13816 will not alter performanceComparing Summary
|
travishathaway
requested changes
Apr 23, 2024
Contributor
travishathaway
left a comment
There was a problem hiding this comment.
Thanks for this submission. Please see my recommendations. Let me know if you have any questions.
travishathaway
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR that adds a docstrings and type hints to
conda.core.index. This change is part of a larger issue: #13437Checklist - did you ...
Add a file to the
newsdirectory (using the template) for the next release's release notes?Add / update necessary tests?
Add / update outdated documentation?