这是indexloc提供的服务，不要输入任何密码
Skip to content

Update disable-ssl-verification.rst #13770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2024
Merged

Update disable-ssl-verification.rst #13770

merged 3 commits into from
Apr 10, 2024
+12 −0

Conversation

@dwr-psandhu
Copy link
Contributor

@dwr-psandhu dwr-psandhu commented Apr 6, 2024 •
edited by travishathaway
Loading

Description

The SSL verification disabling works only with using conda config as described. (conda version 24.3.0). The environment variable method described doesn't work.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@dwr-psandhu dwr-psandhu requested a review from a team as a code owner April 6, 2024 00:01
@conda-bot conda-bot mentioned this pull request Apr 6, 2024
Merged
@conda-bot
Copy link
Contributor

conda-bot commented Apr 6, 2024

We require contributors to sign our Contributor License Agreement and we don't have one on file for @dwr-psandhu.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#910), and ping the bot to refresh the PR.

@travishathaway
Copy link
Contributor

travishathaway commented Apr 8, 2024

@dwr-psandhu,

As previously stated by @conda-bot, we cannot review this pull request until you have signed the CLA agreement.

Also, please add a small description stating why you are suggesting these changes.

@dwr-psandhu
Copy link
Contributor Author

dwr-psandhu commented Apr 8, 2024

The SSL verification disabling works only with using conda config as described. (conda version 24.3.0). The environment variable method described doesn't work.

@dwr-psandhu
Copy link
Contributor Author

dwr-psandhu commented Apr 8, 2024

We require contributors to sign our Contributor License Agreement and we don't have one on file for @dwr-psandhu.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#910), and ping the bot to refresh the PR.

@dwr-psandhu,

As previously stated by @conda-bot, we cannot review this pull request until you have signed the CLA agreement.

Also, please add a small description stating why you are suggesting these changes.

Done.

@travishathaway
Copy link
Contributor

travishathaway commented Apr 9, 2024

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 9, 2024
travishathaway
travishathaway requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggested changes.

@dwr-psandhu @travishathaway
Apply suggestions from code review
83cb8b3 
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
dwr-psandhu
dwr-psandhu commented Apr 9, 2024
View reviewed changes
Copy link
Contributor Author

@dwr-psandhu dwr-psandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks and accepted.

@travishathaway travishathaway merged commit 752c79c into conda:main Apr 10, 2024
ifitchet pushed a commit to ifitchet/conda that referenced this pull request Apr 16, 2024
@dwr-psandhu @travishathaway @ifitchet
Update disable-ssl-verification.rst (conda#13770)
d8bfa07 
* Update disable-ssl-verification.rst

* Apply suggestions from code review

Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>

* removing trailing space

---------

Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@travishathaway travishathaway travishathaway approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

🔎 Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwr-psandhu @conda-bot @travishathaway