这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@padeoe
Copy link
Contributor

@padeoe padeoe commented Jul 8, 2023

Description

I noticed a potential issue in the Conda documentation regarding the proxy server configuration.

Current example:

proxy_servers:
    http: http://user:pass@corp.com:8080
    https: https://user:pass@corp.com:8080

However, the 'https' key should also be specified using the HTTP protocol ('http://'), not HTTPS:

proxy_servers:
    http: http://user:pass@corp.com:8080
    https: http://user:pass@corp.com:8080

The http and https keys indicate the type of traffic to route, not the protocol of the proxy server itself. As written, this could mislead users into thinking that the proxy server should use the HTTPS protocol for https traffic.

I suggest updating the documentation to prevent confusion.

Thank you for considering this issue.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@padeoe padeoe requested a review from a team as a code owner July 8, 2023 16:34
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @padeoe.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#786), and ping the bot to refresh the PR.

@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 21, 2023
@travishathaway
Copy link
Contributor

travishathaway commented Nov 7, 2023

@padeoe,

Just FYI, I committed your suggestion to the branch. I will get the opinion of some others now and will see if this is something we would like to merge to our documentation.

jezdez
jezdez previously approved these changes Nov 7, 2023
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config option is sadly easy to get wrong, maybe it would be good to provide some real world examples or a tutorial?

padeoe and others added 2 commits November 7, 2023 19:07
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@kenodegard kenodegard requested a review from kathatherine July 15, 2024 14:52
Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @padeoe, thank you so much for your patience on this. Your change was a bit lost in the shuffle, but we have rediscovered it! There were some pretty big changes to the conda docs organization since your addition, so I moved your changes to the correct file they should be in. Thank you for your contribution!

@kenodegard kenodegard merged commit d570222 into conda:main Jul 15, 2024
@kenodegard kenodegard mentioned this pull request Jul 17, 2024
61 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 16, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants