这是indexloc提供的服务，不要输入任何密码
Skip to content

Update README with more up-to-date example #12579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2023
Merged

Update README with more up-to-date example #12579

merged 4 commits into from
Apr 12, 2023

Conversation

@vic-ma
Copy link
Contributor

@vic-ma vic-ma commented Apr 9, 2023 •
edited
Loading

Description

Fixes #12280

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@vic-ma vic-ma requested a review from a team as a code owner April 9, 2023 22:27
@conda-bot
Copy link
Contributor

conda-bot commented Apr 9, 2023

We require contributors to sign our Contributor License Agreement and we don't have one on file for @vic-ma.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@vic-ma
Copy link
Contributor Author

vic-ma commented Apr 9, 2023

I signed the CLA on Apr 8.

@dholth
Copy link
Contributor

dholth commented Apr 10, 2023

Would it be better to choose a different package than rust which is usually distributed with rust up and to not use the plus character in the environment name

@vic-ma
Copy link
Contributor Author

vic-ma commented Apr 10, 2023 •
edited
Loading

@dholth

Do you have any suggestions for what to use instead of Rust? I'm not sure what a relevant or popular package might be in the conda world. And yes I think using a hyphen probably makes more sense than plus.

Maybe it should just be the other example suggested in the issue: $ conda create -n flashy-ml-project jupyter pytorch

kenodegard
kenodegard requested changes Apr 11, 2023
View reviewed changes
@vic-ma vic-ma requested a review from kenodegard April 12, 2023 01:38
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 12, 2023
@travishathaway travishathaway merged commit 7ff729d into conda:main Apr 12, 2023
@vic-ma vic-ma deleted the update-readme-example branch April 12, 2023 13:49
@sven6002 sven6002 mentioned this pull request May 22, 2023
Closed
6 tasks
travishathaway added a commit that referenced this pull request Jun 6, 2023
@vic-ma @travishathaway
Update README with more up-to-date example (#12579)
c29f62d 
* Update README with more up-to-date example

* Use PyTorch for example instead

* Update news

---------

Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@travishathaway travishathaway travishathaway approved these changes

@kenodegard kenodegard kenodegard approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

🔎 Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the README with more current / relevant examples

5 participants

@vic-ma @conda-bot @dholth @travishathaway @kenodegard