这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix confusing error message for env create with missing file #11883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 2, 2023
Merged

Fix confusing error message for env create with missing file #11883

merged 9 commits into from
Feb 2, 2023

Conversation

@AdrianFreundQC
Copy link
Contributor

@AdrianFreundQC AdrianFreundQC commented Sep 26, 2022

Description

Fixes #11839: conda env create gives confusing message if environment file does not exist and name is given

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?

Is this significant enough to warrant a news entry? This shouldn't change any behavior, but just select a clearer error message.

  • Add / update necessary tests?
  • Add / update outdated documentation?

@AdrianFreundQC AdrianFreundQC requested a review from a team as a code owner September 26, 2022 21:39
@conda-bot
Copy link
Contributor

conda-bot commented Sep 26, 2022

We require contributors to sign our Contributor License Agreement and we don't have one on file for @AdrianFreundQC.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@AdrianFreundQC
Copy link
Contributor Author

AdrianFreundQC commented Sep 26, 2022

We require contributors to sign our Contributor License Agreement and we don't have one on file for @AdrianFreundQC.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

I already signed the CLA a few minutes before creating this PR.

@AdrianFreundQC AdrianFreundQC mentioned this pull request Sep 27, 2022
Closed
@AdrianFreundQC AdrianFreundQC mentioned this pull request Oct 11, 2022
Closed
2 tasks
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 30, 2023
@travishathaway travishathaway self-assigned this Jan 30, 2023
@travishathaway travishathaway self-requested a review January 30, 2023 05:28
@travishathaway
Copy link
Contributor

travishathaway commented Jan 30, 2023

Hi @AdrianFreundQC,

So far I am a fan of the changes you recommended. I also went ahead and added my own commit to address some other concerns I had.

For one, I found the code complexity to be a bit high in this particular function, so I chose to split it in to two functions. Additionally, I have added doc strings and type hints to make this code a little easier to read for future maintainers.

Thank you very much for the initial changes you submitted. I will now ask for a review from another core team member.

@beeankha beeankha merged commit 8b1635e into conda:main Feb 2, 2023
@AdrianFreundQC AdrianFreundQC deleted the fix-env-create-error-message branch February 2, 2023 13:57
@dholth dholth mentioned this pull request Mar 28, 2023
Closed
@trexfeathers trexfeathers mentioned this pull request Apr 27, 2023
Closed
kenodegard added a commit to kenodegard/conda that referenced this pull request Jun 20, 2023
@kenodegard
Remove conda_env.specs.build_message tests
682dffc 
conda#11883
kenodegard added a commit that referenced this pull request Jun 20, 2023
@kenodegard
Reenable conda_env tests (#12813)
e867ea2 
* Enable all conda_env tests
* Remove outdated test_pip
* Remove outdated conda_env.specs.build_message tests (#11883)
* Remove outdated conda_env.specs.all_spces tests (#7395)
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beeankha beeankha beeankha approved these changes

@travishathaway travishathaway Awaiting requested review from travishathaway

Assignees

@travishathaway travishathaway

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

No open projects
🧭 Planning
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

conda env create gives confusing message if environment file does not exist and name is given

5 participants

@AdrianFreundQC @conda-bot @travishathaway @beeankha @freundTech