Add default value for version parameter when setting build value in conda_build_form method #15025
Conversation
…ld_form if using build parameter and version is not set
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @mmc1718. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1176), and ping the bot to refresh the PR. |
travishathaway
left a comment
There was a problem hiding this comment.
LGTM. Thank you for adding a test and a news item! 👏
|
Because you were the original author for this issue, could you please review it too? |
CodSpeed Instrumentation Performance ReportMerging #15025 will not alter performanceComparing Summary
|
|
Just a couple nits here and there, LGTM otherwise! Thanks! |
Remove redundant assert statement, update punctuation in docs and news Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
|
I had to resolve a merge conflict. The branch should merge once the tests are finished running 🚀 |
Description
Fix for #11200
MatchSpec.conda_build_form: Default to using*as the value forversionparameter in the case where the value is not set (Falsey) inMatchSpecbutbuildparameter is setMatchSpec.conda_build_formChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?