Setup proper pip package with CLI tools and optional dependencies #2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made opendbc an optional dependency to prevent installation conflicts - Added CLI entry points for panda-flash and panda-recover commands - Created CLI module to wrap existing flash/recover functionality - Fixed imports to work with or without opendbc installed - Added MANIFEST.in to include all necessary files in distribution - Configured package-data to include firmware, certs, and build tools This allows pandacan to be installed as a standard pip package and enables replacing the panda git submodule in openpilot with a regular Python dependency. Fixes commaai#2239
- Remove unused noqa directive - Remove whitespace from blank line
Author
adeebshihadeh
requested changes
Jul 31, 2025
python/__init__.py
Outdated
| try: | ||
| from opendbc.car.structs import CarParams | ||
| except ImportError: | ||
| # opendbc is optional |
Contributor
There was a problem hiding this comment.
why is it optional? it shouldn't be
Contributor
There was a problem hiding this comment.
the firmware should be built and packaged at the pandacan package build time
Contributor
|
also where's the openpilot PR for validation? |
Author
|
@adeebshihadeh raising the pr for validation |
Author
|
commaai/openpilot#35857 pr in openpilot |
Author
done |
Contributor
|
The comments weren't addressed. Please do not open another PR unless it's a serious attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup proper pip package
Fixes #2239
Description
This PR implements a comprehensive pip package for panda that includes firmware, certificates, build tools, and CLI entry points. This enables panda to be installed as a standard Python dependency, allowing openpilot to replace the git submodule with a pip installation.
Changes
opendbcan optional dependency to prevent installation conflictspanda-flashandpanda-recovercommandspython/cli.py) to wrap existing flash/recover functionalityMANIFEST.into include all necessary files in distribution__version__at package levelInstallation Options
CLI Tools
After installation, the following commands are available:
panda-flash- Flash panda device(s) with latest firmwarepanda-recover- Recover panda device(s) via DFU modeTesting
python -m buildDemo Video
Screencast.from.2025-07-26.13-49-24.mp4
Notes