这是indexloc提供的服务,不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cirruslabs/tart
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.8.3
Choose a base ref
...
head repository: cirruslabs/tart
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.9.0
Choose a head ref
  • 6 commits
  • 8 files changed
  • 3 contributors

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    63b74f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Fix prune --older-than deleting all cache (#549)

    * Fix `prune --older-than`
    
    * Update Sources/tart/Commands/Prune.swift
    
    Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>
    
    ---------
    
    Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>
    sjchmiela and fkorotkov authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    8653ca4 View commit details
    Browse the repository at this point in the history
  2. Upload debug files to both Sentry projects (#552)

    * Upload debug files to both Sentry projects
    
    Apparently it's not possible to share debug files cross projects. So let's upload to both of them. To one we use in production and one we use for testing.
    
    * Use environment variable
    fkorotkov authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    826e508 View commit details
    Browse the repository at this point in the history
  3. Reclaim disk space only in the very end of tart clone (#553)

    * Reclaim disk space only in the very end of `tart clone`
    
    Please check comments in code for reasoning.
    
    * Phrasing
    
    * Removed hidden argument
    fkorotkov authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1afaa7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad566fa View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Allow mounting a single directory without a name (#555)

    * Allow mounting a single directory without a name
    
    To utilize `VZSingleDirectoryShare` which seems more stable than `VZMultipleDirectoryShare`.
    
    We've been having reports from users that mounted directories occasionally return "no such file" errors when building large projects. I took a stab at reproducing the issue by running https://github.com/devMEremenko/XcodeBenchmark in a mounted directory:
    
    ```bash
    tart run --dir=workdir-test:~/workspace-temp/XcodeBenchmark ventura-xcode
    ```
    
    And I was able to reproduce the "no such file" error on the first try! After looking into the issue I decided to try `VZSingleDirectoryShare` as this PR changes and to my pleasant surprise it all worked like a charm the next run. So it seems there is a bug in `VZMultipleDirectoryShare` integration with virtiofs. Since in most cases users only mount a single directory it makes sense to allow doing it wihtout providing a `name`.
    
    So now it will be possible to run the following command:
    
    ```bash
    tart run --dir=~/workspace-temp/XcodeBenchmark ventura-xcode
    ```
    
    Which will make `~/workspace-temp/XcodeBenchmark` available under `/Volumes/My Shared Files/` without any intermediate directories.
    
    * Reformat
    
    * Updated description
    fkorotkov authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    cf9a3a9 View commit details
    Browse the repository at this point in the history
Loading