这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(breadcrumb): Add missing key property #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

fix(breadcrumb): Add missing key property #4170

merged 3 commits into from
Jul 8, 2025

Conversation

bkepka-box
Copy link
Contributor

@bkepka-box bkepka-box commented Jul 2, 2025 •
edited
Loading

Add missing key property which was causing wrong state of the breadcumbs on nested folders. Without key propery, list of breadcrumbs is not being re-rendered properly after update and ends up in wrong state.

Before:
move-before

After:
move-after

Summary by CodeRabbit

  • Bug Fixes
    • Improved the stability and uniqueness of breadcrumb navigation elements, reducing potential rendering issues.

@bkepka-box bkepka-box requested a review from a team as a code owner July 2, 2025 10:52
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2025 •
edited
Loading

Walkthrough

A unique key prop was added to each Crumb component instance inside the renderBreadcrumbs function in the Breadcrumb component. The key is constructed as a string literal breadcrumb-${i}, where i is the current index, ensuring each rendered Crumb has a distinct identifier.

Changes

File Change Summary
src/components/breadcrumb/Breadcrumb.js Added unique key prop (breadcrumb-${i}) to each Crumb in mapping.

Poem

A breadcrumb trail, now neat and bright,
Each crumb marked with keys just right.
No more warnings in React’s log,
As rabbits hop through code—no fog!
Unique and tidy, onward we go,
Following the path, row by row.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92d7a55 and ea74144.

📒 Files selected for processing (1)
  • src/components/breadcrumb/Breadcrumb.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/breadcrumb/Breadcrumb.js
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint_test_build
  • GitHub Check: Summary
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 2, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/breadcrumb/Breadcrumb.js (1)

74-74: Good fix for React reconciliation, but add defensive programming for undefined ids.

This correctly addresses the breadcrumb state issue by providing unique keys for React's reconciliation process. However, consider handling cases where item.props.id might be undefined.

Apply this defensive improvement:

-                    key={`${item.props.id}-${i}`}
+                    key={`${item.props.id || 'item'}-${i}`}

This ensures that items without an id still get meaningful keys rather than "undefined-0" or "null-1".

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 463839e and 92d7a55.

📒 Files selected for processing (1)
  • src/components/breadcrumb/Breadcrumb.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint_test_build
  • GitHub Check: Summary

@mergify mergify bot merged commit c10b059 into box:master Jul 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@tjuanitas tjuanitas tjuanitas approved these changes

@kkuliczkowski-box kkuliczkowski-box kkuliczkowski-box approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkepka-box @tjuanitas @kkuliczkowski-box