这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Duration timings should use a monotonic clock. #1857

@gbrayut

Description

@gbrayut

Our scollector and collect duration timings are probably being effected by using time.Time which is not monotonic and can be effected by changes to the system time (manual or automated by NTP). Not a huge deal, but likely causes incorrect data in the duration metrics.

Access to a monotonic clock is slated for go 1.8, but there are also packages like goarista and monotime. We could also use it as an opportunity to switch these metrics to use atomic operations instead of locks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions