这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@sebburon
Copy link
Member

@sebburon sebburon commented Nov 1, 2021

Description

Fixes botpress/v12#1532

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore change (refactoring and / or test changes)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test configuration:

  • BP version:
  • Node version:
  • OS:
  • Browser:
  • Binary or source ?:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I've included some media (picture/gif/video) if applicable to show the old and new behavior

Copy link
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allardy allardy merged commit 68eda02 into x-meta Nov 1, 2021
@franklevasseur franklevasseur mentioned this pull request Nov 3, 2021
This was referenced Dec 2, 2021
@sebburon sebburon deleted the sb_authgate_messaging branch December 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants