-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(builtin_image): Modified how we search for Mimetype in the image component. #5401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some URL are passe with all the search query. The Path.extname method didn't return the good format. Some image was not able to rendered.
dc74b0b to
d6cf758
Compare
laurentlp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please illustrate your PR with an example of a carousel that does not display the image so it's easier to review?
modules/channel-web/src/views/lite/components/messages/renderer/FileMessage.tsx
Outdated
Show resolved
Hide resolved
modules/channel-web/src/views/lite/components/messages/renderer/FileMessage.tsx
Outdated
Show resolved
Hide resolved
…r/FileMessage.tsx Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
modules/channel-web/src/views/lite/components/messages/renderer/FileMessage.tsx
Show resolved
Hide resolved
|
For example, if I want to display an Image in the Image.jscarousel.jsReal example |
I discover the carousel component and the built-image doesn't component doesn't display the same image.
Some images could be sent with Query parameters.
Every loaded image/Video/Audio is sent via URL also.