这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Mar 4, 2025

🎟️ Tracking

bitwarden.atlassian.net/browse/PM-17933

📔 Objective

We would like visibility of patch updates for github-actions patch updates, but not necessarily burden the teams with reviewing them all.

To try to accomplish this, we're going to send such updates through the Dependency Dashboard approval flow.

See bitwarden/clients#13234 for corresponding PR in clients to do additional cleanup of the github-action dependency process.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Added approval dashboard for github-actions patch updates. Add approval dashboard for github-actions patch updates Mar 4, 2025
@trmartin4 trmartin4 marked this pull request as ready for review March 4, 2025 20:42
@trmartin4 trmartin4 requested a review from withinfocus March 4, 2025 20:43
@trmartin4 trmartin4 changed the title Add approval dashboard for github-actions patch updates Add approval dashboard review for github-actions patch updates Mar 4, 2025
@trmartin4 trmartin4 changed the title Add approval dashboard review for github-actions patch updates Send github-actions patch updates to approval dashboard Mar 4, 2025
@trmartin4 trmartin4 changed the title Send github-actions patch updates to approval dashboard Send github-actions patch updates to Dependency Dashboard Mar 4, 2025
@trmartin4 trmartin4 changed the title Send github-actions patch updates to Dependency Dashboard Send github-actions patch updates to Dependency Dashboard for approval Mar 4, 2025
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just non-pinned.

@trmartin4 trmartin4 requested a review from withinfocus March 7, 2025 14:43
@trmartin4 trmartin4 merged commit 30f04d7 into main Mar 11, 2025
2 checks passed
@trmartin4 trmartin4 deleted the platform/pm-17933/patch-approval-dashboard branch March 11, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants