这是indexloc提供的服务，不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.4.0
Choose a base ref
...
head repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.5.0
Choose a head ref
  • 13 commits
  • 10 files changed
  • 2 contributors

Commits on Feb 4, 2019

  1. Fix up some markdown in the docstrings. 

    RELNOTES: None.
PiperOrigin-RevId: 230341726
    @thomasvl
    thomasvl committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    887517f View commit details
    Browse the repository at this point in the history

  2. Make everything in apple_support.path_placeholders functions 

    It was a mix of a funcions/constants, this way they all are functions,
hopefully making it easier to use (via consistency).

RELNOTES: apple_support.path_placeholders.sdkroot & apple_support.path_placeholders.xcode are both functions now.
PiperOrigin-RevId: 230407105
    @thomasvl
    thomasvl committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    4ea8ebd View commit details
    Browse the repository at this point in the history

  3. Small docs tweaks to be more self consistent. 

    RELNOTES: None.
PiperOrigin-RevId: 230518245
    @thomasvl
    thomasvl committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    4516179 View commit details
    Browse the repository at this point in the history

  4. Create CODEOWNERS 

    Adding GitHub repo admins as global CODEOWNERS

Closes #12.

RELNOTES: None.
PiperOrigin-RevId: 231773120
    @dslomov @thomasvl
    dslomov authored and thomasvl committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    dbe8f0a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Use skylib's types where possible. 

    RELNOTES: None.
PiperOrigin-RevId: 232306119
    @thomasvl @sergiocampama
    thomasvl authored and sergiocampama committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e558829 View commit details
    Browse the repository at this point in the history

  2. Make the inner rules private since it is an impl detail. 

    RELNOTES: None.
PiperOrigin-RevId: 232532395
    @thomasvl @sergiocampama
    thomasvl authored and sergiocampama committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    43626fc View commit details
    Browse the repository at this point in the history

  3. Document all the needed args to the apple_genrule. 

    RELNOTES: None.
PiperOrigin-RevId: 232699654
    @thomasvl @sergiocampama
    thomasvl authored and sergiocampama committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    8507210 View commit details
    Browse the repository at this point in the history

  4. Provide documentation for the what the modules provides. 

    No long have to read the bzl files! \o/

RELNOTES: None.
PiperOrigin-RevId: 232701066
    @thomasvl @sergiocampama
    thomasvl authored and sergiocampama committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    43860d7 View commit details
    Browse the repository at this point in the history

  5. Misc cleanup. 

    RELNOTES: None
PiperOrigin-RevId: 232713816
    @thomasvl @sergiocampama
    thomasvl authored and sergiocampama committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1d4204d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Move skylib to 0.7.0. 

    RELNOTES: None
PiperOrigin-RevId: 233403851
    @thomasvl
    thomasvl committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    9ba05a4 View commit details
    Browse the repository at this point in the history

  2. Wrap long decls to avoid scrollbars. 

    RELNOTES: None.
PiperOrigin-RevId: 233405555
    @thomasvl
    thomasvl committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    e900558 View commit details
    Browse the repository at this point in the history

  3. Use skylib's types where possible. 

    RELNOTES: None.
PiperOrigin-RevId: 233410396
    @thomasvl
    thomasvl committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    f13c45d View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Add blank line before Returns block. 

    The new buildifier --lint things "Returns" is an argument to the function
unless there is a blank line before it.

RELNOTES: None.
PiperOrigin-RevId: 234011310
    @thomasvl
    thomasvl committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    102135f View commit details
    Browse the repository at this point in the history
Loading