-
Notifications
You must be signed in to change notification settings - Fork 449
feat: Let binding IP address to be configurable via USE_IP environment variable #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lator scenarios Signed-off-by: Karl Baumgartner <178656887+karlbaumg@users.noreply.github.com>
Signed-off-by: Karl Baumgartner <178656887+karlbaumg@users.noreply.github.com>
Signed-off-by: Karl Baumgartner <178656887+karlbaumg@users.noreply.github.com>
d5ae56f to
2d5d803
Compare
|
Thanks @mykola-mokhnach ! I addressed all the comments and tested again with the flow in the PR description. |
Signed-off-by: Karl Baumgartner <178656887+karlbaumg@users.noreply.github.com>
|
@mykola-mokhnach Some of the integration tests seem to be failing but they don't look related. Are they flaky? Do I need to do anything? |
|
yes, they are sometimes flaky due to the general CI slowness. Don't worry about them. I just wanted @KazuCocoa to take another look at the PR and them we could merge it |
KazuCocoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, let us merge once ci worked
| wdaLocalPort?: number; | ||
| wdaRemotePort?: number; | ||
| wdaBaseUrl?: string; | ||
| wdaBindingIP?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@karlbaumg Would you also like to also create a follow-up PR to https://github.com/appium/appium-xcuitest-driver ? |
## [10.2.0](v10.1.4...v10.2.0) (2025-10-31) ### Features * Let binding IP address to be configurable via USE_IP environment variable ([#1066](#1066)) ([70ed7cf](70ed7cf))
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@mykola-mokhnach Sure. While doing that, I noticed some missing pieces that was uncovered when I tested end to end with the driver. #1067 is the fix for those and appium/appium-xcuitest-driver#2645 waits for that PR to be merged. |
|
Hi @karlbaumg, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
We run multiple instances of iOS Simulator on the same macOS host and each gets an IP address from a central IP address management for all simulators in the network, but when they all start WebDriverAgent, they get "address in use" errors as expected.
The suggested way of preventing this is to use
USE_PORTbut that introduces two challenges::8100for WebDriverAgent.This change introduces
USE_IPenvironment variable where users can optionally change the IP that the RoutingHTTPServer binds to remove the need for host-wide synchronization for port number in scenarios where each simulator already has a known IP.Here is how I tested it:
lo0interface so WDA can bind.sudo ifconfig lo0 alias 10.244.1.2When I run it with the following command, e.g. no override, I see usual behavior.