这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wgtmac
Copy link
Member

@wgtmac wgtmac commented Mar 5, 2025

Rationale for this change

See the Avro parity: apache/avro#2934

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Closes #3168

@wgtmac wgtmac requested review from Fokko and gszadovszky March 5, 2025 09:56
@gszadovszky
Copy link
Contributor

@wgtmac, seems you'll need to extend the list in some unit tests.

@wgtmac
Copy link
Member Author

wgtmac commented Mar 5, 2025

@gszadovszky It should be fixed now :)

@wgtmac wgtmac force-pushed the restrict_avro_package branch from f0160bd to 664ce2b Compare March 6, 2025 01:30
@gszadovszky
Copy link
Contributor

@wgtmac, thanks for dealing with this. I think we should have a negative test for it.

@wgtmac wgtmac force-pushed the restrict_avro_package branch from c8656e7 to 7caf4b5 Compare March 7, 2025 08:08
@wgtmac
Copy link
Member Author

wgtmac commented Mar 7, 2025

@gszadovszky @rdblue Thanks for your review! I've added a test case.

Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @wgtmac!

@wgtmac wgtmac merged commit 680edfa into apache:master Mar 7, 2025
7 checks passed
@dongjoon-hyun
Copy link
Member

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict trusted packages in the parquet-avro module

4 participants